-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Methods are not shown for pub type that is imported from other crate #103004
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
This comment was marked as resolved.
This comment was marked as resolved.
Judging by the linked example, this has been fixed. |
Triage 2024: Oof, it's quite hard to come up with an MCVE after the fact ^^'. That would've been useful for doing a bisection and for adding a regression test (or for checking if we already have a similar one). I tried to reproduce it with nightly-2022-10-11 and nightly-2022-10-12 (based on the creation date of this issue and the fact that rustc's API docs get rebuilt 'nightly'). I tried a two file setup of the form: // span.rs
pub mod fatal_error {
pub struct FatalError;
impl FatalError {
pub fn raise(self) -> ! { loop {} }
}
}
// error.rs
pub use span::fatal_error::FatalError;
|
I know that Guillaume fixed a bunch of reexport issues earlier this year and late last year but I'm not super sure how to proceed with this specific issue at this time. |
…=notriddle rustdoc: add two regression tests They were basically copy/pasted from `tests/ui/` to `tests/rustdoc-ui/`. Not sure if it's worth adding these, I can just close these issues as is if you want. This brings the number of https://github.com/rust-lang/rust/labels/T-rustdoc + https://github.com/rust-lang/rust/labels/E-needs-test from 3 down to 1. The remaining one – rust-lang#103004 — is a nasty one to retroactively find a proper(!) test for. Fixes rust-lang#98250. Fixes rust-lang#107872. r? rustdoc
Rollup merge of rust-lang#130173 - fmease:rustdoc-regression-tests, r=notriddle rustdoc: add two regression tests They were basically copy/pasted from `tests/ui/` to `tests/rustdoc-ui/`. Not sure if it's worth adding these, I can just close these issues as is if you want. This brings the number of https://github.com/rust-lang/rust/labels/T-rustdoc + https://github.com/rust-lang/rust/labels/E-needs-test from 3 down to 1. The remaining one – rust-lang#103004 — is a nasty one to retroactively find a proper(!) test for. Fixes rust-lang#98250. Fixes rust-lang#107872. r? rustdoc
Location
I searched for
FatalError
in the rustc docs: https://doc.rust-lang.org/nightly/nightly-rustc/?search=fatalerrorThe first two results are the interesting ones:
rustc_errors::FatalError
andrustc_span::fatal_error::FatalError
When opening the

rustc_span::fatal_error::FatalError
page, the associated methodraise
is shown:When opening the

rustc_errors::FatalError
, the method won't show up:This looks like a bug to me, because you can call the public method through the public export, so that method should either be documented or a page forward should happen to the original struct.
The text was updated successfully, but these errors were encountered: