Skip to content

rustdoc: short vertical spacing on associated types #103782

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jsha opened this issue Oct 31, 2022 · 0 comments · Fixed by #103793
Closed

rustdoc: short vertical spacing on associated types #103782

jsha opened this issue Oct 31, 2022 · 0 comments · Fixed by #103793
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Oct 31, 2022

On https://doc.rust-lang.org/nightly/std/ascii/struct.EscapeDefault.html#impl-Iterator-for-EscapeDefault, the spacing below type Item = u8 and below Item's docblock is too short. Nightly:

image

Stable (correct):

image

I think this is related to #103364, since the selector that is supposed to give the summary a margin-bottom: 0.75em; changed from .implementors-toggle summary to .implementors-toggle > summary.

/cc @notriddle
@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Oct 31, 2022
@notriddle notriddle mentioned this issue Oct 31, 2022
Merged
JohnTitor pushed a commit to JohnTitor/rust that referenced this issue Nov 1, 2022
Rollup merge of rust-lang#103793 - notriddle:notriddle/rustdoc-toggle…
2c7f137 
…-in-impl-items, r=GuillaumeGomez

rustdoc: add margins to all impl-item toggles, not just methods

Fixes rust-lang#103782

## Before

![image](https://user-images.githubusercontent.com/1593513/198943087-8cab8b25-2092-49d6-89b4-caa2989dedf0.png)

## After

![image](https://user-images.githubusercontent.com/1593513/198943111-bc08c2d6-f058-4362-b999-0caf09eb93bf.png)
@bors bors closed this as completed in 791f04e Nov 1, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: add margins to all impl-item toggles, not just methods notriddle/rust
1 participant
@jsha