Skip to content

Fix unstable::dynamic_lib::test::test_loading_cosine on android #10379

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
yichoi opened this issue Nov 9, 2013 · 4 comments · Fixed by #71537
Closed

Fix unstable::dynamic_lib::test::test_loading_cosine on android #10379

yichoi opened this issue Nov 9, 2013 · 4 comments · Fixed by #71537
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. O-android Operating system: Android

Comments

@yichoi
Copy link
Contributor

yichoi commented Nov 9, 2013

Update Bug

test_loading_cosine is being ignored on android. This issue exists to remind that it should be fixed.

This is probably related to: #10356

Old Report

To enable test on android bot #9120

and

test/run-pass/linkage-visibility.rs

It looks to me that this issue is related with #10356
@flaper87 flaper87 changed the title fix to pass unstable::dynamic_lib::test::test_loading_cosine on android Fix unstable::dynamic_lib::test::test_loading_cosine on android Apr 1, 2014
@flaper87
Copy link
Contributor

flaper87 commented Apr 1, 2014

Triage bump. Keeping because it's referenced in the source code. Updated bug report.

@steveklabnik
Copy link
Member

Triage: this test is still disabled, and relevant issues still seem to be open. I don't have an android toolchain to test with further.

tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
rust-lang#10379: Warnings
23049f7
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable test on Android
1af79c6 
Closes rust-lang#10379.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable test on Android
3580084 
Closes rust-lang#10379.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable test on Android
ac14abb 
Closes rust-lang#10379.
tamird added a commit to tamird/rust that referenced this issue Apr 22, 2015
@tamird
Re-enable test on Android
5a68169 
Closes rust-lang#10379.
tamird added a commit to tamird/rust that referenced this issue Apr 23, 2015
@tamird
Re-enable test on Android
499c1f2 
Closes rust-lang#10379.
@steveklabnik
Copy link
Member

Triage: no changes since my last comment.

@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 19, 2017
@steveklabnik
Copy link
Member

Triage: no change

@Mark-Simulacrum Mark-Simulacrum mentioned this issue Apr 24, 2020
Merged
@bors bors closed this as completed in 4199ef1 Apr 26, 2020
Jarcho pushed a commit to Jarcho/rust that referenced this issue Feb 26, 2023
@bors
Auto merge of rust-lang#10380 - Alexendoo:needless-lifetime-macro-exp…
803ce88 
…ansion, r=xFrednet

Ignore lifetimes from differing contexts in `needless_lifetimes`

Fixes rust-lang#10379

changelog: [`needless_lifetimes`]: Don't lint signatures in macros if the lifetime is a metavariable
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. O-android Operating system: Android
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for self-opening Mark-Simulacrum/rust
4 participants
@flaper87 @steveklabnik @yichoi @Mark-Simulacrum