Skip to content

In 1.64 split-debuginfo = "unpacked" was ignored on Windows while in 1.65 it fails to build #103976

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Yatekii opened this issue Nov 4, 2022 · 5 comments
Closed

In 1.64 split-debuginfo = "unpacked" was ignored on Windows while in 1.65 it fails to build #103976

Yatekii opened this issue Nov 4, 2022 · 5 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another.

Comments

@Yatekii
Copy link

Yatekii commented Nov 4, 2022

Code

I tried this code:

[profile.dev]
split-debuginfo = "unpacked"

I expected to see this happen: The compilation on windows succeds but does not actually use the feature.

Instead, this happened: The compilation on windows lets me know this feature is unavailable.

Version it worked on

It most recently worked on: Rust 1.64

Version with regression

rustc --version --verbose:

rustc 1.65.0 (897e37553 2022-11-02)

This is the Cargo.toml in question: https://github.com/probe-rs/probe-rs/blob/master/Cargo.toml#L21.
This is the CI pipeline that started to fail with th 1.65 release: https://github.com/probe-rs/probe-rs/actions/runs/3390410063/jobs/5634519715

I am not sure if this would be a cargo or rustc issue. Pardon my ignorance.

Best,
Noah
@Yatekii Yatekii added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Nov 4, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Nov 4, 2022
@kpreid
Copy link
Contributor

kpreid commented Nov 5, 2022

I hit this in my CI too.

Here are some other (not Windows-specific) reports of new failures when using split-debuginfo: #100657, #103932

@kamirr kamirr mentioned this issue Nov 8, 2022
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 8, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104104 - kamirr:master, r=lcnr
1827496 
Add split-debuginfo print option

This option prints all supported values for `-Csplit-debuginfo=..`, i.e. only stable ones on stable/beta and all of them on nightly/dev.

Motivated by 1.65.0 regression causing builds with the following entry in `Cargo.toml` to fail on Windows:
```toml
[profile.dev]
split-debuginfo = "unpacked"
```

See rust-lang/cargo#11347 for details.

This will lead to closing rust-lang#103976.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 8, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104104 - kamirr:master, r=lcnr
aca8cdf 
Add split-debuginfo print option

This option prints all supported values for `-Csplit-debuginfo=..`, i.e. only stable ones on stable/beta and all of them on nightly/dev.

Motivated by 1.65.0 regression causing builds with the following entry in `Cargo.toml` to fail on Windows:
```toml
[profile.dev]
split-debuginfo = "unpacked"
```

See rust-lang/cargo#11347 for details.

This will lead to closing rust-lang#103976.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 8, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104104 - kamirr:master, r=lcnr
2f37412 
Add split-debuginfo print option

This option prints all supported values for `-Csplit-debuginfo=..`, i.e. only stable ones on stable/beta and all of them on nightly/dev.

Motivated by 1.65.0 regression causing builds with the following entry in `Cargo.toml` to fail on Windows:
```toml
[profile.dev]
split-debuginfo = "unpacked"
```

See rust-lang/cargo#11347 for details.

This will lead to closing rust-lang#103976.
Manishearth added a commit to Manishearth/rust that referenced this issue Nov 8, 2022
@Manishearth
Rollup merge of rust-lang#104104 - kamirr:master, r=lcnr
925045b 
Add split-debuginfo print option

This option prints all supported values for `-Csplit-debuginfo=..`, i.e. only stable ones on stable/beta and all of them on nightly/dev.

Motivated by 1.65.0 regression causing builds with the following entry in `Cargo.toml` to fail on Windows:
```toml
[profile.dev]
split-debuginfo = "unpacked"
```

See rust-lang/cargo#11347 for details.

This will lead to closing rust-lang#103976.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Nov 8, 2022
@GuillaumeGomez
Rollup merge of rust-lang#104104 - kamirr:master, r=lcnr
92f1c6f 
Add split-debuginfo print option

This option prints all supported values for `-Csplit-debuginfo=..`, i.e. only stable ones on stable/beta and all of them on nightly/dev.

Motivated by 1.65.0 regression causing builds with the following entry in `Cargo.toml` to fail on Windows:
```toml
[profile.dev]
split-debuginfo = "unpacked"
```

See rust-lang/cargo#11347 for details.

This will lead to closing rust-lang#103976.
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Nov 9, 2022
@paul-hansen paul-hansen mentioned this issue Nov 30, 2022
Open
@kkoski kkoski mentioned this issue Dec 25, 2022
Closed
@weihanglo weihanglo mentioned this issue Jan 27, 2023
Merged
dubrowgn added a commit to dubrowgn/shooter that referenced this issue Feb 2, 2023
@dubrowgn
Remove split-debuginfo from Cargo.toml
9968867 
Windows does not support split-debuginfo, and as of rust 1.65, results
in build failure. Simple remove the directive, since it was an
experiment anyway.

See: rust-lang/rust#103976
@Jules-Bertholet
Copy link
Contributor

@rustbot label -regression-untriaged +regression-from-stable-to-stable

@rustbot rustbot added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. I-prioritize Issue: Indicates that prioritization has been requested for this issue. and removed regression-untriaged Untriaged performance or correctness regression. labels Jun 10, 2023
@apiraino
Copy link
Contributor

@Jules-Bertholet I think #104104 was meant to close this. But this issue still reproduces, right?

@Jules-Bertholet
Copy link
Contributor

I wouldn't know, I just updated the label based on the issue description.

@ehuss
Copy link
Contributor

ehuss commented Jun 14, 2023

I'm going to close as I believe this is fixed in 1.68 via rust-lang/cargo#11347. Feel free to comment if that doesn't seem to be the case.

@ehuss ehuss closed this as completed Jun 14, 2023
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jun 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ehuss @Yatekii @kpreid @apiraino @rustbot @Jules-Bertholet