Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

spurious test failure: rc::rc_from_vec_opt on window #104563

Closed
matthiaskrgr opened this issue Nov 18, 2022 · 1 comment · Fixed by #104571
Closed

spurious test failure: rc::rc_from_vec_opt on window #104563

matthiaskrgr opened this issue Nov 18, 2022 · 1 comment · Fixed by #104571
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-bug Category: This is a bug.

Comments

@matthiaskrgr
Copy link
Member 


failures:

---- rc::rc_from_vec_opt stdout ----
thread 'rc::rc_from_vec_opt' panicked at 'assertion failed: `(left == right)`
  left: `-169216`,
 right: `8`: Vector allocation not reused', library\alloc\tests\rc.rs:217:9


failures:
    rc::rc_from_vec_opt

test result: FAILED. 652 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.29s

Test was added in https://github.com/rust-lang/rust/pull/104205/files#diff-7c162f3385758481b661bb4120fe36635a2933c200bd7713a34ba9e47bac411fR220
@matthiaskrgr matthiaskrgr added C-bug Category: This is a bug. A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) labels Nov 18, 2022
This was referenced Nov 18, 2022
Merged
Merged
@matthiaskrgr
Copy link
Member Author

@clubby789 could you please have a look at why this test fails on windows sometimes?
Maybe we have to disable it on that platform?

This was referenced Nov 18, 2022
Closed
Merged
@matthiaskrgr matthiaskrgr mentioned this issue Nov 18, 2022
Merged
@bors bors closed this as completed in 62c627c Nov 19, 2022
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#104571 - clubby789:remove-vec-rc-opt, r=the8472
77aeac1 
Revert Vec/Rc storage reuse opt

Remove the optimization for using storage added by rust-lang#104205.
The perf wins were pretty small, and it relies on non-guarenteed behaviour. On platforms that don't implement shrinking in place, the performance will be significantly worse.

While it could be gated to platforms that do this (such as GNU), I don't think it's worth the overhead of maintaining it for very small gains. (rust-lang#104565, rust-lang#104563)

cc `@RalfJung` `@matthiaskrgr`

Fixes rust-lang#104565
Fixes rust-lang#104563
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert Vec/Rc storage reuse opt clubby789/rust
1 participant
@matthiaskrgr