Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

#[doc(inline)] reexports have both duplicated docs and missing docs #108281

Closed
GuillaumeGomez opened this issue Feb 20, 2023 · 0 comments · Fixed by #108310
Closed

#[doc(inline)] reexports have both duplicated docs and missing docs #108281

GuillaumeGomez opened this issue Feb 20, 2023 · 0 comments · Fixed by #108310
Assignees
@GuillaumeGomez
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

Linked to #59368.

#[doc(hidden)]
pub fn bar() {}

/// Displayed
#[doc(inline)]
pub use	crate::bar as Bar;
#[doc(inline)]
/// Hello
pub use crate::Bar as Bar2;

Bar will have Displayed Displayed as documentation whereas Bar2 will have Hello Hello (but it should also have the docs from Bar).
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Feb 20, 2023
@GuillaumeGomez GuillaumeGomez self-assigned this Feb 20, 2023
@GuillaumeGomez GuillaumeGomez changed the title #[doc(inline)] reexports get both duplicated docs and missing docs as well #[doc(inline)] reexports have both duplicated docs and missing docs as well Feb 21, 2023
@GuillaumeGomez GuillaumeGomez changed the title #[doc(inline)] reexports have both duplicated docs and missing docs as well #[doc(inline)] reexports have both duplicated docs and missing docs Feb 21, 2023
@GuillaumeGomez GuillaumeGomez mentioned this issue Feb 21, 2023
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 21, 2023
@GuillaumeGomez
Add regression test for rust-lang#108281
fec6ad6
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 22, 2023
@matthiaskrgr
Rollup merge of rust-lang#108310 - GuillaumeGomez:fix-reexports-dupli…
bd89a11 
…cated-attributes, r=notriddle

rustdoc: Fix duplicated attributes for first reexport

Fixes rust-lang#108281.

r? `@notriddle`
@bors bors closed this as completed in 8d33b78 Feb 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Fix duplicated attributes for first reexport GuillaumeGomez/rust
1 participant
@GuillaumeGomez