creating a TypeErrCtxt should only be possible if we emit an error
#108810
Labels
A-type-system
Area: Type system
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
E-medium
Call for participation: Medium difficulty. Experience needed to fix: Intermediate.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
lcnr
added
C-cleanup
estebank
added
the
T-compiler
lcnr
added
the
E-medium
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this issue
Apr 13, 2023
cleanup our region error API - require `TypeErrCtxt` to always result in an error, closing rust-lang#108810 - move `resolve_regions_and_report_errors` to the `ObligationCtxt` - call `process_registered_region_obligations` in `resolve_regions` - move `resolve_regions` into the `outlives` submodule - add `#[must_use]` to functions returning lists of errors r? types
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Apr 13, 2023
cleanup our region error API - require `TypeErrCtxt` to always result in an error, closing rust-lang#108810 - move `resolve_regions_and_report_errors` to the `ObligationCtxt` - call `process_registered_region_obligations` in `resolve_regions` - move `resolve_regions` into the `outlives` submodule - add `#[must_use]` to functions returning lists of errors r? types
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Apr 13, 2023
cleanup our region error API - require `TypeErrCtxt` to always result in an error, closing rust-lang#108810 - move `resolve_regions_and_report_errors` to the `ObligationCtxt` - call `process_registered_region_obligations` in `resolve_regions` - move `resolve_regions` into the `outlives` submodule - add `#[must_use]` to functions returning lists of errors r? types
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
there are a lot of methods on
TypeErrCtxtwhich should only be used for diagnostics. To assert that this is the case we should emit adelay_span_bugwhen creating (or probably when dropping so that-Ztreat-err-as-bugkeeps working nicely) this context.This means that we can't use
infcx.err_ctxt().check_region_obligations_and_report_errors()as that creates aTypeErrCtxteven though we don't emit any error.Its probably easiest to use the same split as
select_all_or_error, always usingresolve_regionswhich returns a#[must_use]list of errors and then manually callingreport_region_errorsThe text was updated successfully, but these errors were encountered: