Skip to content

add bootstrap tests for detecting src and out #109120

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
jyn514 opened this issue Mar 14, 2023 · 0 comments
Open

add bootstrap tests for detecting src and out #109120

jyn514 opened this issue Mar 14, 2023 · 0 comments
Assignees
@onur-ozkan
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 14, 2023

I was thinking about the following cases when I wrote the comment in #109055

  1. Running bootstrap from the source root.
  2. Running from a subdirectory of the source root.
  3. Running from outside the source root.
  4. Running on a different machine from where bootstrap was compiled (which will be important for no python in shell scripts #107812). You can mostly replicate this by renaming the source root so it no longer exists on disk.
  5. Running with --build-dir.
  6. Running with $RUST_BOOTSTRAP_CONFIG set in the environment and build-dir set in the file.

Originally posted by @jyn514 in #109055 (comment)
@jyn514 jyn514 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. labels Mar 14, 2023
@onur-ozkan onur-ozkan mentioned this issue Mar 15, 2023
Merged
@jyn514 jyn514 mentioned this issue Mar 17, 2023
Open
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Apr 6, 2023
@Dylan-DPC
Rollup merge of rust-lang#109162 - ozkanonur:extend_detect_src_and_ou…
cb22866 
…t_test, r=jyn514

extend `detect_src_and_out` test

> I was thinking about the following cases when I wrote the comment in rust-lang#109055
>
> 1. Running bootstrap from the source root.
> 2. Running from a subdirectory of the source root.
> 3. Running from outside the source root.
> 4. Running on a different machine from where bootstrap was compiled (which will be important > for rust-lang#107812). You can mostly replicate this by renaming the source root so it no longer exists on disk.
> 5. Running with `--build-dir`.
> 6. Running with `$RUST_BOOTSTRAP_CONFIG` set in the environment and `build-dir` set in the file.

Tested all the topics mentioned above. All worked fine. The test is now also covers if build dir is manually specified in config.

r? `@jyn514`

helps rust-lang#109120 partially
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 6, 2023
@matthiaskrgr
Rollup merge of rust-lang#109162 - ozkanonur:extend_detect_src_and_ou…
159b61e 
…t_test, r=jyn514

extend `detect_src_and_out` test

> I was thinking about the following cases when I wrote the comment in rust-lang#109055
>
> 1. Running bootstrap from the source root.
> 2. Running from a subdirectory of the source root.
> 3. Running from outside the source root.
> 4. Running on a different machine from where bootstrap was compiled (which will be important > for rust-lang#107812). You can mostly replicate this by renaming the source root so it no longer exists on disk.
> 5. Running with `--build-dir`.
> 6. Running with `$RUST_BOOTSTRAP_CONFIG` set in the environment and `build-dir` set in the file.

Tested all the topics mentioned above. All worked fine. The test is now also covers if build dir is manually specified in config.

r? ``@jyn514``

helps rust-lang#109120 partially
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 6, 2023
@bors
Auto merge of rust-lang#109162 - ozkanonur:extend_detect_src_and_out_…
28a2928 
…test, r=jyn514

extend `detect_src_and_out` test

> I was thinking about the following cases when I wrote the comment in rust-lang#109055
>
> 1. Running bootstrap from the source root.
> 2. Running from a subdirectory of the source root.
> 3. Running from outside the source root.
> 4. Running on a different machine from where bootstrap was compiled (which will be important > for rust-lang#107812). You can mostly replicate this by renaming the source root so it no longer exists on disk.
> 5. Running with `--build-dir`.
> 6. Running with `$RUST_BOOTSTRAP_CONFIG` set in the environment and `build-dir` set in the file.

Tested all the topics mentioned above. All worked fine. The test is now also covers if build dir is manually specified in config.

r? `@jyn514`

helps rust-lang#109120 partially
@onur-ozkan onur-ozkan removed the E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. label Sep 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@onur-ozkan onur-ozkan

Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jyn514 @onur-ozkan