-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
windows-gnu thin-lto test linking error regression #109797
Comments
Disable test_profile test on windows-gnu This disables the `test_profile` test on windows-gnu due to a regression in nightly, see rust-lang/rust#109797.
…=weihanglo Disable test_profile test on windows-gnu This disables the `test_profile` test on windows-gnu due to a regression in nightly, see rust-lang/rust#109797.
WG-prioritization assigning priority (Zulip discussion). @rustbot label -I-prioritize +P-high |
…=weihanglo Disable test_profile test on windows-gnu This disables the `test_profile` test on windows-gnu due to a regression in nightly, see rust-lang/rust#109797.
After PR #109806 lands, we should keep this open and tag it as E-needs-test, to try to catch regressions while this linker bug persists (assuming our CI covers this case...) |
Workaround rust-lang#109797 on windows-gnu The addition of `#[inline]` here in rust-lang#108089 caused an unrelated linking issue (rust-lang#109797). This PR removes this attribute again on Windows to avoid regressions.
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#109806 (Workaround rust-lang#109797 on windows-gnu) - rust-lang#109957 (diagnostics: account for self type when looking for source of unsolved type variable) - rust-lang#109960 (Fix buffer overrun in bootstrap and (test-only) symlink_junction) - rust-lang#110013 (Label `non_exhaustive` attribute on privacy errors from non-local items) - rust-lang#110016 (Run collapsed GUI test in mobile mode as well) - rust-lang#110022 (fix: fix regression in rust-lang#109203) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
…=weihanglo Disable test_profile test on windows-gnu This disables the `test_profile` test on windows-gnu due to a regression in nightly, see rust-lang/rust#109797.
Workaround #109797 on windows-gnu The addition of `#[inline]` here in rust-lang/rust#108089 caused an unrelated linking issue (rust-lang/rust#109797). This PR removes this attribute again on Windows to avoid regressions.
I don't think that issue is fixed, it has been worked around in std but there are libs which also want to inline funcions using statics like here https://github.com/tokio-rs/tracing/blob/bac25085fcea68ca30b8e19b8981fbd689f53735/tracing-core/src/dispatch.rs#L503 causing issues in downstream crates: astral-sh/ruff#9245 |
Still here? Looks similar #120679 (comment) when bumping memchr to 2.6.0 |
As I described in my previous comment the workaround only affects std library. |
Since this issue is linked in various places, let's at least put the workaround in a visible spot (the bottom of the issue is not ideal but better than searching linked issues): WorkaroundUse LLD ( |
Fixed in the nightly, likely by #129079 |
I tried this code:
on nightly-x86_64-pc-windows-gnu build with:
fails with the following:
This was discovered in Cargo's testsuite.
Bisected this to #108089. cc @Zoxc @bjorn3
Workaround
Use LLD (
RUSTFLAGS=-Clink-arg=-fuse-ld=lld
assuming you have it in PATH), or use fat LTO, or disable LTO.Meta
rustc --version --verbose
:The text was updated successfully, but these errors were encountered: