-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Use a stable release of LLVM #11849
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
(leaving to team mtg...) |
This doesn't necessarily mean upstreaming all our patches as long as Rust can be built with a stable release of LLVM. |
As a reminder taken from some comments in #4259, this specific issue is quite important for packaging. For instance, it won't be possible to upload a Rust package to fedora repos unless we start using stable llvm releases. |
FWIW, I gave it a try and it doesn't compile with stable llvm (version 3.4). When my queue of things to do gets shorter, I could give this a try (unless someone wants to start playing with this right away) |
I believe this is done. We've been using upstream llvm 3.3 and 3.4 (Now upgrading to 3.5 #13513) for our travis builds. I'll leave the |
Hurray! Yes, we will be fully compatible with 3.5 by the time it comes out. |
…_to_ref-tests, r=blyxyas Add tests for issues rust-lang#10285, rust-lang#10286, rust-lang#10289, rust-lang#10287 Fixes rust-lang#10285. Fixes rust-lang#10286. Fixes rust-lang#10289. Fixes rust-lang#10287. This PR simply adds tests for the listed issues as they're already implemented so we can close them. r? `@blyxyas` changelog:none
Requires #4259. Nominating. Do we want to be able to claim this for 1.0?
The text was updated successfully, but these errors were encountered: