Skip to content

set --change-id in ci #119296

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jyn514 opened this issue Dec 25, 2023 · 2 comments · Fixed by #119298
Closed

set --change-id in ci #119296

jyn514 opened this issue Dec 25, 2023 · 2 comments · Fixed by #119298
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 25, 2023

right now, every ci job starts with this warning:

WARNING: The `change-id` is missing in the `config.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations.
NOTE: to silence this warning, add `change-id = 119124` at the top of `config.toml`

this is silly. it's ci. nobody is configuring different defaults. we should always silence this.

unfortunately this is somewhat tricky now that change-id is no longer stored in config.example.toml. maybe we can set ./configure --set change-id=${github.event.number} in src/ci/run.sh? i am not sure how the change tracker handles a PR number it doesn't recognize.

cc @onur-ozkan
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 25, 2023
@onur-ozkan
Copy link
Member

2 options come to my mind:

  • Print only if it's not a CI (although this might not be a good idea as it will affect any CI pipeline, including package releases from Linux distributions).
  • Set change-id to very large value (like 9999999) in run.sh

@onur-ozkan onur-ozkan added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 25, 2023
@onur-ozkan
Copy link
Member

i am not sure how the change tracker handles a PR number it doesn't recognize.

If the change-id is greater than the latest ID existing in CHANGE_TRACKER_HISTORY, we don't do anything (as this frequently occurs during checkouts between new and old commits). However, if it is smaller than the latest ID and does not exist in CHANGE_TRACKER_HISTORY then we panic.

@onur-ozkan onur-ozkan mentioned this issue Dec 25, 2023
Merged
fmease added a commit to fmease/rust that referenced this issue Jan 3, 2024
@fmease
Rollup merge of rust-lang#119298 - onur-ozkan:silence-change-tracker-…
e1f8d68 
…warning-for-ci, r=Mark-Simulacrum

suppress change-tracker warnings in CI containers

Fixes rust-lang#119296
@bors bors closed this as completed in 907922b Jan 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 3, 2024
@rust-timer
Unrolled build for rust-lang#119298
d8aa6d7 
Rollup merge of rust-lang#119298 - onur-ozkan:silence-change-tracker-warning-for-ci, r=Mark-Simulacrum

suppress change-tracker warnings in CI containers

Fixes rust-lang#119296
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

suppress change-tracker warnings in CI containers onur-ozkan/rust
3 participants
@jyn514 @onur-ozkan @rustbot