Skip to content

Repeated spurious rustdoc test failure: rustdoc-gui/help-page #126430

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
RalfJung opened this issue Jun 13, 2024 · 2 comments
Closed

Repeated spurious rustdoc test failure: rustdoc-gui/help-page #126430

RalfJung opened this issue Jun 13, 2024 · 2 comments
Labels
A-CI Area: Our Github Actions CI A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Jun 13, 2024 •
edited
Loading

I've seen this fail in two PRs today, e.g. here

  /checkout/tests/rustdoc-gui/help-page.goml help-page... FAILED
  Error:  `tests/rustdoc-gui/utils.goml` line 16
      from `tests/rustdoc-gui/help-page.goml` line 23
      from `tests/rustdoc-gui/help-page.goml` line 32: Error: Evaluation failed: The following errors happened: [localStorage item "rustdoc-theme" (of value "ayu") != "null"]: for command `assert-local-storage: {"rustdoc-theme": |theme|}`

Cc @rust-lang/rustdoc
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 13, 2024
This was referenced Jun 13, 2024
Merged
Merged
Merged
@Noratrieb Noratrieb added A-testsuite Area: The testsuite used to check the correctness of rustc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) C-bug Category: This is a bug. A-CI Area: Our Github Actions CI and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 13, 2024
@lqd lqd mentioned this issue Jun 13, 2024
Merged
@tgross35 tgross35 mentioned this issue Jun 13, 2024
Merged
@GuillaumeGomez
Copy link
Member

Taking a look.

@lqd lqd mentioned this issue Jun 13, 2024
Merged
@GuillaumeGomez GuillaumeGomez mentioned this issue Jun 13, 2024
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jun 13, 2024
@matthiaskrgr
Rollup merge of rust-lang#126436 - GuillaumeGomez:reduce-gui-tests-fl…
6483e65 
…akyness, r=lqd

Reduce rustdoc GUI tests flakyness

Fixes rust-lang#126430.

r? `@notriddle`
@lqd lqd mentioned this issue Jun 13, 2024
Closed
@cuviper cuviper mentioned this issue Jun 13, 2024
Merged
@tgross35 tgross35 mentioned this issue Jun 13, 2024
Merged
@fmease fmease mentioned this issue Jun 14, 2024
Closed
@RalfJung RalfJung mentioned this issue Jun 14, 2024
Merged
@GuillaumeGomez
Copy link
Member

It was "fixed" in #127082 (still no idea why this test in particular is failing).

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-CI Area: Our Github Actions CI A-spurious Area: Spurious failures in builds (spuriously == for no apparent reason) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce rustdoc GUI tests flakyness GuillaumeGomez/rust
4 participants
@RalfJung @GuillaumeGomez @rustbot @Noratrieb