Skip to content

Tracking Issue for sha512_sm_x86 #126624

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
3 of 4 tasks
sayantn opened this issue Jun 18, 2024 · 3 comments
Open
3 of 4 tasks

Tracking Issue for sha512_sm_x86 #126624

sayantn opened this issue Jun 18, 2024 · 3 comments
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC I-libs-api-nominated Nominated for discussion during a libs-api team meeting. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@sayantn
Copy link
Contributor

sayantn commented Jun 18, 2024 •
edited
Loading

This tracks the integration of Intel's SHA512, SM3 and SM4 instruction sets in Rust

The feature gate for the issue is #![feature(sha512_sm_x86)].

Steps

  • Add the feature to rustc
  • Add the target-features
  • Add the intrinsics to stdarch
  • Stabilization PR

Implementation History
@sayantn sayantn added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jun 18, 2024
@sayantn sayantn changed the title Tracking Issue for x86_sha512_sm Tracking Issue for sha512_sm_x86 Jun 19, 2024
This was referenced Jun 19, 2024
Merged
Merged
@rustbot rustbot added A-SIMD Area: SIMD (Single Instruction Multiple Data) A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. labels Jun 24, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu
ddac035 
Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate

This is an effort towards rust-lang#126624. This adds support for these 3 target-features and introduces the feature flag `sha512_sm_x86`, which would gate these target-features and the yet-to-be-implemented detection and intrinsics in stdarch.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 2, 2024
@matthiaskrgr
Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu
84b403f 
Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate

This is an effort towards rust-lang#126624. This adds support for these 3 target-features and introduces the feature flag `sha512_sm_x86`, which would gate these target-features and the yet-to-be-implemented detection and intrinsics in stdarch.
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 2, 2024
@jieyouxu
Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu
4a4c089 
Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate

This is an effort towards rust-lang#126624. This adds support for these 3 target-features and introduces the feature flag `sha512_sm_x86`, which would gate these target-features and the yet-to-be-implemented detection and intrinsics in stdarch.
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 2, 2024
@jieyouxu
Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu
e4b4136 
Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate

This is an effort towards rust-lang#126624. This adds support for these 3 target-features and introduces the feature flag `sha512_sm_x86`, which would gate these target-features and the yet-to-be-implemented detection and intrinsics in stdarch.
jieyouxu added a commit to jieyouxu/rust that referenced this issue Aug 3, 2024
@jieyouxu
Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu
c7b684e 
Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate

This is an effort towards rust-lang#126624. This adds support for these 3 target-features and introduces the feature flag `sha512_sm_x86`, which would gate these target-features and the yet-to-be-implemented detection and intrinsics in stdarch.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 3, 2024
@matthiaskrgr
Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu
8aa1829 
Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate

This is an effort towards rust-lang#126624. This adds support for these 3 target-features and introduces the feature flag `sha512_sm_x86`, which would gate these target-features and the yet-to-be-implemented detection and intrinsics in stdarch.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Aug 3, 2024
@rust-timer
Unrolled build for rust-lang#126704
c3249c8 
Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu

Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate

This is an effort towards rust-lang#126624. This adds support for these 3 target-features and introduces the feature flag `sha512_sm_x86`, which would gate these target-features and the yet-to-be-implemented detection and intrinsics in stdarch.
@newpavlov newpavlov mentioned this issue Dec 19, 2024
Open
@sayantn sayantn mentioned this issue Apr 29, 2025
Merged
@sayantn
Copy link
Contributor Author

sayantn commented May 4, 2025 •
edited
Loading

cc @rust-lang/lang
cc @Amanieu

I believe these are ready to be stabilized, as all the implementation jobs are done.

@rustbot label I-lang-nominated

@rustbot rustbot added the I-lang-nominated Nominated for discussion during a lang team meeting. label May 4, 2025
@zonyitoo zonyitoo mentioned this issue May 6, 2025
Merged
newpavlov pushed a commit to RustCrypto/utils that referenced this issue May 6, 2025
@zonyitoo
cpufeatures: x86 support of sha512, sm3, sm4 (#1181)
716d766 
https://en.wikipedia.org/wiki/CPUID#EAX=7,_ECX=1:_Extended_Features

Add supports of `sha512`, `sm3` and `sm4` in x86.

Rust support: rust-lang/rust#126624
@traviscross
Copy link
Contributor

@rustbot labels -I-lang-nominated

We do our stabilization FCPs on stabilization PRs. Please submit and nominate one of those for us along with the stabilization report. See the new template for that:

rust-lang/rustc-dev-guide#2219

@rustbot rustbot removed the I-lang-nominated Nominated for discussion during a lang team meeting. label May 7, 2025
@traviscross traviscross added the T-lang Relevant to the language team, which will review and decide on the PR/issue. label May 7, 2025
This was referenced May 7, 2025
Open
Draft
@sayantn
Copy link
Contributor Author

sayantn commented May 7, 2025

The lang-stabilization is being done in #140767, so let's do the libs stabilization here (intrinsics and runtime detection, in rust-lang/stdarch#1796)

@rustbot label I-libs-api-nominated

@rustbot rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label May 7, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-SIMD Area: SIMD (Single Instruction Multiple Data) A-target-feature Area: Enabling/disabling target features like AVX, Neon, etc. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC I-libs-api-nominated Nominated for discussion during a libs-api team meeting. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@traviscross @rustbot @sayantn