Skip to content

Upgrade sundown to hoedown in rustdoc #12776

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
huonw opened this issue Mar 9, 2014 · 1 comment
Closed

Upgrade sundown to hoedown in rustdoc #12776

huonw opened this issue Mar 9, 2014 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@huonw
Copy link
Member

huonw commented Mar 9, 2014

https://github.com/hoedown/hoedown

Benefits include upstream being maintained, and correctly parsing codefences, e.g. parsing

 ```
 a
 ~~~
 b
 ~~~
 c
 ```

as a single nested code block

a 
~~~
b
~~~
c

rather than two separate ones

a

b

c
@huonw huonw added the A-rustdoc label Mar 9, 2014
@adrientetar
Copy link
Contributor

#9377 just got necro'ed. :) I +1 this.

cc @alexcrichton, this would allow us to drop the hacks from bb8ac21.

@huonw huonw mentioned this issue Mar 18, 2014
Closed
@lifthrasiir lifthrasiir mentioned this issue Apr 16, 2014
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 25, 2022
@bors
Auto merge of rust-lang#12776 - matklad:nosu, r=matklad
f2c2c36 
try fixing spurious CI failures on windows

It seems like it may be related to self-update? Anyways, I think we
should be disabling self-update on CI
flip1995 pushed a commit to flip1995/rust that referenced this issue May 17, 2024
@bors
Auto merge of rust-lang#12783 - shanretoo:fix-assigning-clones, r=bly…
baf2a23 
…xyas

fix: use hir_with_context to produce correct snippets for assigning_clones

The `assigning_clones` lint is producing wrong output when the assignment is a macro call.
Since Applicability level `Unspecified` will never be changed inside `hir_with_applicability`, so it is safe here to replace `hir_with_applicability` with `hir_with_context` to generate snippets of the macro call instead of the expansion.

fixes rust-lang#12776

changelog: [`assigning_clones`]: use `hir_with_context` to produce correct snippets
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huonw @adrientetar