Skip to content

Remove binary_asm_labels once the LLVM issue is fixed #127937

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
tgross35 opened this issue Jul 18, 2024 · 0 comments
Open

Remove binary_asm_labels once the LLVM issue is fixed #127937

tgross35 opened this issue Jul 18, 2024 · 0 comments
Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-cleanup Category: PRs that clean code up or issues documenting cleanup. L-binary_asm_labels Lint: LLVM parses labels like 0, 1, 10, 11, etc. oddly T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@tgross35
Copy link
Contributor

This issue is just to track llvm/llvm-project#99547. After that is fixed, we can remove binary_asm_labels and allow using 0: and 1: on x86.

Relevant issues:

Relevant PRs:
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 18, 2024
@tgross35 tgross35 added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-inline-assembly Area: Inline assembly (`asm!(…)`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jul 18, 2024
@workingjubilee workingjubilee added the L-binary_asm_labels Lint: LLVM parses labels like 0, 1, 10, 11, etc. oddly label Aug 4, 2024
K900 added a commit to K900/nix-ld that referenced this issue Oct 1, 2024
@K900
Work around LLVM bug
9583c80 
Rust 1.81 will refuse to compile this otherwise.

See rust-lang/rust#127937
@K900 K900 mentioned this issue Oct 1, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-inline-assembly Area: Inline assembly (`asm!(…)`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. C-cleanup Category: PRs that clean code up or issues documenting cleanup. L-binary_asm_labels Lint: LLVM parses labels like 0, 1, 10, 11, etc. oddly T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tgross35 @workingjubilee @rustbot