optimize attribute can be applied to anything

[oli-obk]

I tried this code:

#![feature(optimize_attribute)]
#[optimize(cake, bar, foo, bop)]
type Foo = ();

I expected to see this happen: compilation failure because of attribute on an item where it makes no sense

Instead, this happened: compiled successfully

Meta

rustc --version --verbose:

1.82.0-nightly

2024-07-31 28a58f2fa7f0c46b8fab

cc #54882

see #128444 for where to fix this issue

[clubby789]

I think #128458 should have fixed this

[clubby789]

warning: attribute should be applied to function or closure
 --> poc.rs:2:1
  |
2 | #[optimize(cake, bar, foo, bop)]
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_attributes)]` on by default

It emits unused_attributes since that's what's specified in the RFC. Perhaps that should be amended to an error, which would be more consistent with other diagnostics like this

[ibilalkayy]

Is this issue still available to work on?

[Borgerr]

@rustbot claim

[Borgerr]

I'll be submitting a PR for this in case the RFC dictates errors in place of warnings, at least in this instance.