Skip to content

Feature gate #[lang] attributes and extern "rust-intrinsic" {} blocks #12858

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
huonw opened this issue Mar 13, 2014 · 1 comment · Fixed by #15066
Closed

Feature gate #[lang] attributes and extern "rust-intrinsic" {} blocks #12858

huonw opened this issue Mar 13, 2014 · 1 comment · Fixed by #15066
Milestone
1.0

Comments

@huonw
Copy link
Member

huonw commented Mar 13, 2014

These can change dramatically day-to-day, and are incomplete in various ways (e.g. #9307).
@brson brson added this to the 1.0 milestone Jun 19, 2014
@brson
Copy link
Contributor

brson commented Jun 19, 2014

1.0, P-backcompat-lang

@pcwalton pcwalton mentioned this issue Jun 21, 2014
Merged
pcwalton added a commit to pcwalton/rust that referenced this issue Jun 24, 2014
@pcwalton
librustc: Feature gate lang items and intrinsics.
5466d13 
If you define lang items in your crate, add `#[feature(lang_items)]`.

If you define intrinsics (`extern "rust-intrinsic"`), add
`#[feature(intrinsics)]`.

Closes rust-lang#12858.

[breaking-change]
bors added a commit that referenced this issue Jun 24, 2014
@bors
auto merge of #15066 : pcwalton/rust/lang-and-intrinsic-feature-gate,…
d9611da 
… r=alexcrichton

If you define lang items in your crate, add `#[feature(lang_items)]`.

If you define intrinsics (`extern "rust-intrinsic"`), add
`#[feature(intrinsics)]`.

Closes #12858.

[breaking-change]

r? @brson
fasterthanlime pushed a commit to fasterthanlime/rust that referenced this issue Jul 26, 2022
@bors
Auto merge of rust-lang#12858 - fasterthanlime:proc-macro-srv-bin, r=…
7ba94a8 
…Veykril

Add `rust-analyzer-proc-macro-srv` binary, use it if found in sysroot

This adds a `bin` crate which simply runs `proc_macro_srv::cli::run()` (it does no CLI argument parsing, nothing).

The intent is to build that crate in Rust CI as part of the `dist::Rustc` component, then ship it in the sysroot: it would probably land in something like `~/.rustup/toolchains/nightly-2022-07-23-x86_64-unknown-linux-gnu/libexec/proc-macro-srv-cli`.

This makes rust-lang/rustup#3022 less pressing. (Instead of teaching RA about rustup components, we simply teach it to look in the sysroot via `rustc --print sysroot`. If it can't find `proc-macro-srv-cli`, it falls back to its own `proc-macro` subcommand).

This is closely related to rust-lang/rust-analyzer#12803 (but doesn't close it yet).

Things to address now:

  * [ ] What should the binary be named? What should the crate be named? We can pick different names with `[bin]` in the `Cargo.toml`

Things to address later:

  * Disable the "multi ABI compatibility scheme" when building that binary in Rust CI (that'll probably happen in `rust-lang/rust`)
  * Teaching RA to look in the sysroot

Things to address much, much later:

  * Is JSON a good fit here
  * Do we want to add versioning to future-proof it?
  * Other bikesheds

When built with `--features sysroot` on `nightly-2022-07-23-x86_64-unknown-linux-gnu`, the binary is 7.4MB. After stripping debuginfo, it's 2.6MB. When compressed to `.tar.xz`, it's 619KB.

In a Zulip discussion, `@jyn514` and `@Mark-Simulacrum` seemed to think that those sizes weren't a stopper for including the binary in the rustc component, even before we shrink it down further.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

librustc: Feature gate lang items and intrinsics. pcwalton/rust
4 participants
@alexcrichton @brson @huonw @thestinger