-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Tracking Issue for const_mut_cursor
#130801
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
…htriplett Mark `get_mut` and `set_position` in `std::io::Cursor` as const. Relevant tracking issue: rust-lang#130801 The methods `get_mut` and `set_position` can trivially be marked as const due to rust-lang#57349 being stabilised.
…htriplett Mark `get_mut` and `set_position` in `std::io::Cursor` as const. Relevant tracking issue: rust-lang#130801 The methods `get_mut` and `set_position` can trivially be marked as const due to rust-lang#57349 being stabilised.
Rollup merge of rust-lang#130800 - bjoernager:const-mut-cursor, r=joshtriplett Mark `get_mut` and `set_position` in `std::io::Cursor` as const. Relevant tracking issue: rust-lang#130801 The methods `get_mut` and `set_position` can trivially be marked as const due to rust-lang#57349 being stabilised.
@rust-lang/libs-api these are two trivial already-stable methods that (I assume) haven't been made const-stable years ago just because they need mutable references. Now that we have mutable references in const, there's no reason to wait any longer with making them const-stable IMO. |
@rfcbot fcp merge
Their non-mut counterparts, |
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
…u-se Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios. Closes: rust-lang#130801 This PR stabilises the `const_mut_cursor` feature gate.
Rollup merge of rust-lang#136634 - bjoernager:const-mut-cursor, r=m-ou-se Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios. Closes: rust-lang#130801 This PR stabilises the `const_mut_cursor` feature gate.
…u-se Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios. Closes: rust-lang#130801 This PR stabilises the `const_mut_cursor` feature gate.
Uh oh!
There was an error while loading. Please reload this page.
Feature gate:
#![feature(const_mut_cursor)]
This is a tracking issue for marking the
get_mut
andset_position
methods instd::io::Cursor
as const.Public API
Steps / History
get_mut
andset_position
instd::io::Cursor
as const. #130800Cursor::{get_mut, set_position}
inconst
scenarios. #136634Unresolved Questions
into_inner
?The text was updated successfully, but these errors were encountered: