-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Tracking Issue for const_char_classify
#132241
Comments
Support `char::is_digit` in const contexts. This PR implements [`feature(const_char_is_digit)` rust-lang#132241](rust-lang#132241)
Rollup merge of rust-lang#132242 - ultrabear:const_is_digit, r=scottmcm Support `char::is_digit` in const contexts. This PR implements [`feature(const_char_is_digit)` rust-lang#132241](rust-lang#132241)
const_char_is_digit
const_char_classify
…=jhpratt make char::is_whitespace unstably const I am adding this to the existing rust-lang#132241 feature gate, since `is_digit` and `is_whitespace` seem similar enough that one can group them together.
make char::is_whitespace unstably const I am adding this to the existing rust-lang/rust#132241 feature gate, since `is_digit` and `is_whitespace` seem similar enough that one can group them together.
make char::is_whitespace unstably const I am adding this to the existing rust-lang/rust#132241 feature gate, since `is_digit` and `is_whitespace` seem similar enough that one can group them together.
@rust-lang/libs-api @rust-lang/wg-const-eval these are two fairly small methods that have been stable since 1.0 and that are trivial to const-stabilize, so I think we should go ahead and do that. :) impl char {
pub const fn is_digit(self, radix: u32) -> bool;
pub const fn is_whitespace(self) -> bool;
} |
@rfcbot fcp merge |
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
🔔 This is now entering its final comment period, as per the review above. 🔔 |
Feature gate:
#![feature(const_char_is_digit)]
#![feature(const_char_classify)]
This is a tracking issue for supporting
char::is_digit
andchar::is_whitespace
in const scenarios.Public API
Steps / History
char::is_digit
in const contexts. #132242Unresolved Questions
The text was updated successfully, but these errors were encountered: