Skip to content

make check-stage1 is broken #13247

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
pnkfelix opened this issue Apr 1, 2014 · 1 comment · Fixed by #13260
Closed

make check-stage1 is broken #13247

pnkfelix opened this issue Apr 1, 2014 · 1 comment · Fixed by #13260

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Apr 1, 2014

Original title: "compiletest has implicit dependency on libnative"

  • compiletest has implicit dependency on libnative

When I tried to do make check-stage1, I get the following:

oxidize: x86_64-apple-darwin/stage0/lib/rustlib/x86_64-apple-darwin/bin/compiletest
/Users/fklock/Dev/Mozilla/rust-ltms/src/compiletest/compiletest.rs:1:1: 1:1 error: can't find crate for `native`
/Users/fklock/Dev/Mozilla/rust-ltms/src/compiletest/compiletest.rs:1 // Copyright 2012 The Rust Project Developers. See the COPYRIGHT
                                                                     ^
error: aborting due to previous error

@alexcrichton says this is because, despite compiletest's continued use of libgreen, there is an implicit attempt to link in libnative unless one puts in a #![no_start] attribute into the crate attributes.

I plan to try to fix this pronto.


  • After fixing the above, I get:
    /Users/fklock/Dev/Mozilla/rust.git/src/test/run-pass-fulldeps/quote-unused-sp-no-warning.rs:16:1: 16:21 error: found possibly newer version of crate `std` which `syntax` depends on
    /Users/fklock/Dev/Mozilla/rust.git/src/test/run-pass-fulldeps/quote-unused-sp-no-warning.rs:16 extern crate syntax;
                                                                                                   ^~~~~~~~~~~~~~~~~~~~
    /Users/fklock/Dev/Mozilla/rust.git/src/test/run-pass-fulldeps/quote-unused-sp-no-warning.rs:16:1: 16:21 note: perhaps this crate needs to be recompiled?
    /Users/fklock/Dev/Mozilla/rust.git/src/test/run-pass-fulldeps/quote-unused-sp-no-warning.rs:16 extern crate syntax;
                                                                                                   ^~~~~~~~~~~~~~~~~~~~
    error: aborting due to previous error

    ------------------------------------------

    task '[run-pass] run-pass-fulldeps/quote-unused-sp-no-warning.rs' failed at 'explicit failure', /Users/fklock/Dev/Mozilla/rust.git/src/compiletest/runtest.rs:962


failures:
    [run-pass] run-pass-fulldeps/quote-unused-sp-no-warning.rs

So there's another separate problem blocking make check-stage1 from working.

@pnkfelix
Copy link
Member Author

pnkfelix commented Apr 2, 2014

Still working on this, there was a new problem that came up (run-pass-fulldeps needs libsyntax to have been rebuilt), so I've updated the description and the title to reflect the more general issue here.

@pnkfelix pnkfelix changed the title compiletest has implicit dependency on libnative make check-stage1 is broken Apr 2, 2014
@bors bors closed this as completed in 0651d27 Apr 5, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Sep 5, 2024
Add new check for passing pointers to an `asm!` block with `nomem` option

changelog: Add new check for passing pointers to an `asm!` block with `nomem` option

Continuing work from rust-lang#127063
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant