Skip to content

cdb debuginfo test failures #133107

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jieyouxu opened this issue Nov 16, 2024 · 5 comments
Closed

cdb debuginfo test failures #133107

jieyouxu opened this issue Nov 16, 2024 · 5 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Nov 16, 2024 •
edited
Loading

EDIT: see https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/msvc.20update.20causing.20debuginfo.20failures, runner image update may have updated cdb?

I can't tell if this is a github runner issue, something changed with our x86_64-msvc CI, or a genuine flaky test, but these three tests have been failing on x86_64-msvc:

tests\debuginfo\numeric-types.rs
tests\debuginfo\range-types.rs
tests\debuginfo\unit-type.rs

#133094 (comment)
#133097 (comment)
#133029 (comment)
#132569 (comment)

But

rust/tests/debuginfo/numeric-types.rs

Line 1 in 46e8d20

//@ compile-flags:-g
was last modified 3 months ago and I don't recall seeing any PRs recently modifying debuginfo for cdb.

Opening this issue to track the failures.
@jieyouxu jieyouxu added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Nov 16, 2024
@clubby789
Copy link
Contributor

#132566 (comment)

@jieyouxu jieyouxu changed the title Spurious cdb debuginfo test failures cdb debuginfo test failures Nov 16, 2024
@jieyouxu jieyouxu mentioned this issue Nov 16, 2024
Open
@jieyouxu jieyouxu added the O-windows-msvc Toolchain: MSVC, Operating system: Windows label Nov 16, 2024
@ehuss ehuss mentioned this issue Nov 16, 2024
Merged
@jieyouxu
Copy link
Member Author

Looks like the output did change following new cdb version in CI

Microsoft (R) Windows Debugger Version 10.0.26100.2161 AMD64

@jieyouxu jieyouxu self-assigned this Nov 16, 2024
This was referenced Nov 16, 2024
Open
Open
Merged
@jieyouxu jieyouxu removed their assignment Nov 16, 2024
@jieyouxu
Copy link
Member Author

jieyouxu commented Nov 16, 2024 •
edited
Loading

Updating cdb annotations in #133115 but I can't tell if they improved/regressed/whatever, so keeping this issue open even after #133115 merges for the cdb/debuginfo experts to follow-up.

@jieyouxu jieyouxu removed the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Nov 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 16, 2024
@bors
Auto merge of rust-lang#133115 - jieyouxu:cdb, r=ChrisDenton
f6afd1b 
Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161`

GitHub CI runners [recently updated to Windows Server 2022 (20241113)](https://github.com/actions/runner-images/releases/tag/win22%2F20241113.3) which included Windows Software Development Kit version `10.1.26100.1742`, which transitively shipped a `cdb` version `10.0.26100.2161`.

This changed some cdb output, causing 3 debuginfo tests to fail (see rust-lang#133107, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/msvc.20update.20causing.20debuginfo.20failures):

```
tests\debuginfo\numeric-types.rs
tests\debuginfo\range-types.rs
tests\debuginfo\unit-type.rs
```

I updated cdb annotations for these 3 tests locally with a matching `cdb` version. However, I am not by any means a cdb expert nor debuginfo expert, I just reblessed the tests to match whatever the new cdb version produces to unblock the tree. It is certainly possible that debuginfo improved/regressed/both with the newer cdb version.

try-job: x86_64-msvc
@jieyouxu
Copy link
Member Author

Marking numeric-types.rs as 64-bit only for now to unblock the tree (in #133115), follow-up investigations should try to see if that can be made to work with i686-msvc (64-bit isize vs 32-bit isize and thus different underlying int type display).

bors added a commit to rust-lang-ci/rust that referenced this issue Nov 16, 2024
@bors
Auto merge of rust-lang#133115 - jieyouxu:cdb, r=chrisdenton
f2a3542 
Update cdb annotations for some debuginfo tests with cdb `10.0.26100.2161`

GitHub CI runners [recently updated to Windows Server 2022 (20241113)](https://github.com/actions/runner-images/releases/tag/win22%2F20241113.3) which included Windows Software Development Kit version `10.1.26100.1742`, which transitively shipped a `cdb` version `10.0.26100.2161`.

This changed some cdb output, causing 3 debuginfo tests to fail (see rust-lang#133107, https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/msvc.20update.20causing.20debuginfo.20failures):

```
tests\debuginfo\numeric-types.rs
tests\debuginfo\range-types.rs
tests\debuginfo\unit-type.rs
```

I updated cdb annotations for these 3 tests locally with a matching `cdb` version. However, I am not by any means a cdb expert nor debuginfo expert, I just reblessed the tests to match whatever the new cdb version produces to unblock the tree. It is certainly possible that debuginfo improved/regressed/both with the newer cdb version.

try-job: x86_64-msvc
@jieyouxu jieyouxu mentioned this issue Dec 23, 2024
Open
@jieyouxu
Copy link
Member Author

Closing this issue in favor of a more specific issue for the outstanding test coverage regression in #134683.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clubby789 @jieyouxu