-
Notifications
You must be signed in to change notification settings - Fork 13.4k
rustdoc-json: Not enough info after paths change. #135600
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
A-rustdoc-json
Area: Rustdoc JSON backend
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
MCVE: #![no_std]
pub type Foo = core::str::SplitAsciiWhitespace<'static>; Which produces (abridged): {
"index": {
"0": {
"id": 0,
"inner": {
"type_alias": {
"generics": {"params": [], "where_predicates": []},
"type": {
"resolved_path": {
"args": {"angle_bracketed": {"args": [{"lifetime": "'static"}], "constraints": []}},
"id": 1,
"name": "SplitAsciiWhitespace"
}
}
}
},
"name": "Foo"
},
"2": {
"id": 2,
"inner": {"module": {"is_crate": true, "is_stripped": false, "items": [0]}},
"name": "mcve"
}
},
"paths": {
"0": {"crate_id": 0, "kind": "type_alias", "path": ["mcve", "Foo"]},
"1": {"crate_id": 1, "kind": "struct", "path": ["core", "str", "iter", "SplitAsciiWhitespace"]}
},
"root": 2
} And there's no way to produce |
4 tasks
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 24, 2025
…r=GuillaumeGomez rustdoc-json: Rename `Path::name` to `path`, and give it the path again. Closes: rust-lang#135600. Reverts rust-lang#134880 (Effectively, but not actually, as the `FORMAT_VERSION` needs to be bumped, changed docs/tests). CC `@AS1100K.` Also CC `@obi1kenobi` `@LukeMathWalker` Still needs before being merge-ready: - [x] Tests for cross-crate paths - [x] (Maybe) Document what the field does. - [x] Decide if the field rename is good (rust-lang#135799 (comment)) - [ ] Squash commits. r? `@GuillaumeGomez`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 24, 2025
Rollup merge of rust-lang#135799 - aDotInTheVoid:skrrt-skrrt-revrrt, r=GuillaumeGomez rustdoc-json: Rename `Path::name` to `path`, and give it the path again. Closes: rust-lang#135600. Reverts rust-lang#134880 (Effectively, but not actually, as the `FORMAT_VERSION` needs to be bumped, changed docs/tests). CC `@AS1100K.` Also CC `@obi1kenobi` `@LukeMathWalker` Still needs before being merge-ready: - [x] Tests for cross-crate paths - [x] (Maybe) Document what the field does. - [x] Decide if the field rename is good (rust-lang#135799 (comment)) - [ ] Squash commits. r? `@GuillaumeGomez`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
A-rustdoc-json
Area: Rustdoc JSON backend
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Uh oh!
There was an error while loading. Please reload this page.
Originally posted by @obi1kenobi in #134880 (comment)
The text was updated successfully, but these errors were encountered: