Skip to content

rustc, rustdoc: give nicer feedback when no arguments are given #1394

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
kud1ing opened this issue Dec 30, 2011 · 0 comments
Closed

rustc, rustdoc: give nicer feedback when no arguments are given #1394

kud1ing opened this issue Dec 30, 2011 · 0 comments
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
0.1 first support...

Comments

@kud1ing
Copy link

kud1ing commented Dec 30, 2011

A "how to use" information instead of the "upcall fail" messages would be nice:

$ rustc
error: No input filename given.
rust: upcall fail 'explicit failure', ../src/comp/driver/driver.rs:570
rust: domain main @0x10202aa00 root task failed

$ rustdoc
rust: upcall fail 'bounds check', ../src/rustdoc/rustdoc.rs:186
rust: domain main @0x10202aa00 root task failed

"cargo"'s feedback is quite good:

$ cargo
Usage: cargo <verb> [args...]
  init                                 Fetch default sources
  install [source/]package-name        Install by name
  install uuid:[source/]package-uuid   Install by uuid
  list [source]                        List packages
  search <name | '*'> [tags...]        Search packages
  sync                                 Sync all sources
  usage                                This
@ghost ghost assigned graydon Dec 30, 2011
Kobzol pushed a commit to Kobzol/rust that referenced this issue Dec 30, 2024
@tshepang @camelid
make date-check more lightweight (rust-lang#1394)
b50a5e7 
* make date-check lightweight

This avoids having to write the date twice when updating date-check.

Before "As of <-- 2022-07 --> July 2022"
After "As of July 2022"

* please clippy

* update date-check docs

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

rust-lang/rustc-dev-guide#1394 (review)

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

rust-lang/rustc-dev-guide#1394 (review)

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

* this breaks markdown

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

This led to a more robust regex, though making the tool more picky.
It also found a wrong date format that was missed.

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

* accept review suggestion

This was reverted by mistake

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

* use a more simple fn

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

Much more clean

* nit

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* avoid a failed regex

Also, test new shape

* adjust to new regex (which uses named groups)

New regex was introduced by 456008cc35de0597d26fec0030ee5db8a0c2fb65

Co-authored-by: Noah Lev <camelidcamel@gmail.com>
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
@tshepang @camelid
make date-check more lightweight (rust-lang#1394)
481233d 
* make date-check lightweight

This avoids having to write the date twice when updating date-check.

Before "As of <-- 2022-07 --> July 2022"
After "As of July 2022"

* please clippy

* update date-check docs

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

rust-lang/rustc-dev-guide#1394 (review)

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

rust-lang/rustc-dev-guide#1394 (review)

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

* this breaks markdown

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

This led to a more robust regex, though making the tool more picky.
It also found a wrong date format that was missed.

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

* accept review suggestion

This was reverted by mistake

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

* use a more simple fn

* address review comment

rust-lang/rustc-dev-guide#1394 (comment)

Much more clean

* nit

* accept review suggestion

Co-authored-by: Noah Lev <camelidcamel@gmail.com>

* avoid a failed regex

Also, test new shape

* adjust to new regex (which uses named groups)

New regex was introduced by 456008cc35de0597d26fec0030ee5db8a0c2fb65

Co-authored-by: Noah Lev <camelidcamel@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
0.1 first supported public release
Development

No branches or pull requests
2 participants
@graydon @kud1ing