-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustc opt parsing: -C "llvm-args=-mcpu=arm1176jzf-s" doesn't get whole input #14228
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
This is not a bug in rustc opt parsing, but rather this message is being printed from LLVM. From what I can tell, rustc is correctly passing through the Perhaps we could be clearer with an error? |
Can anyone confirm if this is still an issue? There have been at least a few LLVM upgrades since this was last updated |
It seems to be an issue still. Only certain kinds of arguments are accepted by llvm-args, different kinds of pass options are accepted. I don't think it's intentional.. |
I believe this is the same issue as #26338. The arguments recognized by |
I'm going to close in favor of #26338, since I agree that issue is the real cause of this one. |
This PR enables the new ability to collapse `if` statements containing comments (without losing them) in Clippy sources, excluding tests and lintcheck, where the default behaviour (no collapsing in presence of comments) is preserved. To be applied after rust-lang#14231. When it is applied, rust-lang#14455 will be marked as ready for review, then rust-lang#14228 afterwards. changelog: none r? ghost
This was reported by a user on IRC.
https://gist.github.com/thebreadcat/b47c0f49d736a990b556
I am logging it here in the hopes that I remember to look at it again later when I look into hacking a little on getopts (for #14223)
The text was updated successfully, but these errors were encountered: