Skip to content

Impl resolution may try to access unresolved types #1494

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
marijnh opened this issue Jan 11, 2012 · 0 comments
Closed

Impl resolution may try to access unresolved types #1494

marijnh opened this issue Jan 11, 2012 · 0 comments

Comments

@marijnh
Copy link
Contributor

marijnh commented Jan 11, 2012

When collecting the set of impls in a mod that hasn't been resolved yet, you get an error when one of the impls implements an iface, since the ty_path for the iface doesn't have a def associated with it yet.

This should probably be fixed by moving the gathering of impls for imports into a pass after the normal resolution pass.
@ghost ghost assigned marijnh Jan 11, 2012
marijnh added a commit that referenced this issue Jan 13, 2012
@marijnh
Remove workaround for issue #1494
7150643 
We have a snapshot that includes the fix.
@marijnh marijnh removed their assignment Jun 16, 2014
@daxpedda daxpedda mentioned this issue Oct 31, 2023
Merged
Kobzol pushed a commit to Kobzol/rust that referenced this issue Dec 30, 2024
@compiler-errors @spastorino
Update traits/resolution.md (rust-lang#1494)
50bbf26 
* Update `traits/resolution.md`

Co-authored by: @lcnr and @spastorino

* Update src/traits/resolution.md

* Wrapping

* Update src/traits/resolution.md

Co-authored-by: Santiago Pastorino <spastorino@gmail.com>

Co-authored-by: Santiago Pastorino <spastorino@gmail.com>
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
@compiler-errors @spastorino
Update traits/resolution.md (rust-lang#1494)
d300e00 
* Update `traits/resolution.md`

Co-authored by: @lcnr and @spastorino

* Update src/traits/resolution.md

* Wrapping

* Update src/traits/resolution.md

Co-authored-by: Santiago Pastorino <spastorino@gmail.com>

Co-authored-by: Santiago Pastorino <spastorino@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marijnh