Skip to content

Feature gate import shadowing #16464

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
brson opened this issue Aug 12, 2014 · 3 comments · Fixed by #16482
Closed

Feature gate import shadowing #16464

brson opened this issue Aug 12, 2014 · 3 comments · Fixed by #16482
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Milestone
1.0

Comments

@brson
Copy link
Contributor

brson commented Aug 12, 2014

Tracking rust-lang/rfcs#116
@brson brson mentioned this issue Aug 12, 2014
Merged
@pcwalton
Copy link
Contributor

Nominating for 1.0, P-backcompat-lang.

@pcwalton
Copy link
Contributor

I'd like to just register my displeasure with the scope creep here, but of course I won't stand in the way.

@pcwalton pcwalton mentioned this issue Aug 13, 2014
Merged
@pnkfelix
Copy link
Member

P-backcompat-lang, 1.0

@pnkfelix pnkfelix added this to the 1.0 milestone Aug 14, 2014
pcwalton added a commit to pcwalton/rust that referenced this issue Aug 17, 2014
@pcwalton
librustc: Forbid external crates, imports, and/or items from being
f3bd29a 
declared with the same name in the same scope.

This breaks several common patterns. First are unused imports:

    use foo::bar;
    use baz::bar;

Change this code to the following:

    use baz::bar;

Second, this patch breaks globs that import names that are shadowed by
subsequent imports. For example:

    use foo::*; // including `bar`
    use baz::bar;

Change this code to remove the glob:

    use foo::{boo, quux};
    use baz::bar;

Or qualify all uses of `bar`:

    use foo::{boo, quux};
    use baz;

    ... baz::bar ...

Finally, this patch breaks code that, at top level, explicitly imports
`std` and doesn't disable the prelude.

    extern crate std;

Because the prelude imports `std` implicitly, there is no need to
explicitly import it; just remove such directives.

The old behavior can be opted into via the `import_shadowing` feature
gate. Use of this feature gate is discouraged.

This implements RFC rust-lang#116.

Closes rust-lang#16464.

[breaking-change]
bors added a commit that referenced this issue Aug 17, 2014
@bors
auto merge of #16482 : pcwalton/rust/resolve-shadowing, r=brson
44eca60 
declared with the same name in the same scope.

This breaks several common patterns. First are unused imports:

    use foo::bar;
    use baz::bar;

Change this code to the following:

    use baz::bar;

Second, this patch breaks globs that import names that are shadowed by
subsequent imports. For example:

    use foo::*; // including `bar`
    use baz::bar;

Change this code to remove the glob:

    use foo::{boo, quux};
    use baz::bar;

Or qualify all uses of `bar`:

    use foo::{boo, quux};
    use baz;

    ... baz::bar ...

Finally, this patch breaks code that, at top level, explicitly imports
`std` and doesn't disable the prelude.

    extern crate std;

Because the prelude imports `std` implicitly, there is no need to
explicitly import it; just remove such directives.

The old behavior can be opted into via the `import_shadowing` feature
gate. Use of this feature gate is discouraged.

This implements RFC #116.

Closes #16464.

[breaking-change]

r? @brson
pcwalton added a commit to pcwalton/rust that referenced this issue Aug 17, 2014
@pcwalton
librustc: Forbid external crates, imports, and/or items from being
7f928d1 
declared with the same name in the same scope.

This breaks several common patterns. First are unused imports:

    use foo::bar;
    use baz::bar;

Change this code to the following:

    use baz::bar;

Second, this patch breaks globs that import names that are shadowed by
subsequent imports. For example:

    use foo::*; // including `bar`
    use baz::bar;

Change this code to remove the glob:

    use foo::{boo, quux};
    use baz::bar;

Or qualify all uses of `bar`:

    use foo::{boo, quux};
    use baz;

    ... baz::bar ...

Finally, this patch breaks code that, at top level, explicitly imports
`std` and doesn't disable the prelude.

    extern crate std;

Because the prelude imports `std` implicitly, there is no need to
explicitly import it; just remove such directives.

The old behavior can be opted into via the `import_shadowing` feature
gate. Use of this feature gate is discouraged.

This implements RFC rust-lang#116.

Closes rust-lang#16464.

[breaking-change]
bors added a commit that referenced this issue Aug 17, 2014
@bors
auto merge of #16482 : pcwalton/rust/resolve-shadowing, r=brson
4a5654f 
declared with the same name in the same scope.

This breaks several common patterns. First are unused imports:

    use foo::bar;
    use baz::bar;

Change this code to the following:

    use baz::bar;

Second, this patch breaks globs that import names that are shadowed by
subsequent imports. For example:

    use foo::*; // including `bar`
    use baz::bar;

Change this code to remove the glob:

    use foo::{boo, quux};
    use baz::bar;

Or qualify all uses of `bar`:

    use foo::{boo, quux};
    use baz;

    ... baz::bar ...

Finally, this patch breaks code that, at top level, explicitly imports
`std` and doesn't disable the prelude.

    extern crate std;

Because the prelude imports `std` implicitly, there is no need to
explicitly import it; just remove such directives.

The old behavior can be opted into via the `import_shadowing` feature
gate. Use of this feature gate is discouraged.

This implements RFC #116.

Closes #16464.

[breaking-change]

r? @brson
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

librustc: Forbid external crates, imports, and/or items from being pcwalton/rust
3 participants
@brson @pcwalton @pnkfelix