Skip to content

Require inherent impls to be located adjacent to their types #17059

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
pcwalton opened this issue Sep 7, 2014 · 1 comment
Closed

Require inherent impls to be located adjacent to their types #17059

pcwalton opened this issue Sep 7, 2014 · 1 comment
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Milestone
1.0

Comments

@pcwalton
Copy link
Contributor

pcwalton commented Sep 7, 2014

RFC: rust-lang/rfcs#155

Nominating for 1.0, P-backcompat-lang.
@pcwalton pcwalton added I-nominated B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. A-resolve Area: Name/path resolution done by `rustc_resolve` specifically labels Sep 7, 2014
@pcwalton pcwalton mentioned this issue Sep 11, 2014
Closed
@pnkfelix pnkfelix added this to the 1.0 milestone Sep 11, 2014
@pnkfelix
Copy link
Member

1.0, P-backcompat-lang.

bors added a commit that referenced this issue Sep 14, 2014
@bors
auto merge of #17163 : pcwalton/rust/impls-next-to-struct, r=alexcric…
13037a3 
…hton

type they provide an implementation for.

This breaks code like:

    mod foo {
        struct Foo { ... }
    }

    impl foo::Foo {
        ...
    }

Change this code to:

    mod foo {
        struct Foo { ... }

        impl Foo {
            ...
        }
    }

Closes #17059.

RFC #155.

[breaking-change]

r? @brson
lnicola pushed a commit to lnicola/rust that referenced this issue Apr 20, 2024
@bors
Auto merge of rust-lang#17059 - Kohei316:refactor-generate-function, …
ebd7a59 
…r=Veykril

internal: make function builder create ast directly

I am working on rust-lang#17050.
In the process, I noticed a place in the code that could be refactored.
Currently, the `function builder` creates the `ast` through the `function template` , but those two processes can be combined into one function.
I thought I should work on this first and created a PR.
lnicola pushed a commit to lnicola/rust that referenced this issue Apr 20, 2024
@bors
Auto merge of rust-lang#17059 - Kohei316:refactor-generate-function, …
0636e7c 
…r=Veykril

internal: make function builder create ast directly

I am working on rust-lang#17050.
In the process, I noticed a place in the code that could be refactored.
Currently, the `function builder` creates the `ast` through the `function template` , but those two processes can be combined into one function.
I thought I should work on this first and created a PR.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

librustc: Forbid inherent implementations that aren't adjacent to the pcwalton/rust
2 participants
@pcwalton @pnkfelix