-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Implement where clauses #17657
Comments
P-backcompat-libs, but not 1.0. |
I've been working on this somewhat in the background. The patch is somewhat more involved than I imagined initially because where clauses are more powerful than I initially imagined -- in particular, there are lots of bits of code that assume that there is an intrinsic set of bounds associated with a specific type parameter, whereas where clauses make those things scope dependent. We've been steadily removed them and by now all the deep connections are almost entirely eradicated (@pcwalton's work in #17864 is, I think, the last bit). In my branch, I was removing all the lists of bounds from type parameters and adding in a list of predicates instead. It occurred to me today that it might also be possible to phase support for this in faster by doing it in two stages: first, leaving the code as is but adding a generalized list of predicates, and then removing the bounds lists. I'm not sure which is better. |
@nikomatsakis I'm looking into this after our conversation this morning. Let me know if there are any other tracking issues I should be following. I am going to go dig up your branch and work on it during the afternoon session. |
@nikomatsakis would it be possible to update the check list at some point? would be good to check at glance what remains. It is fine if it happens after #20020 lands. |
Nominating for removal from P-backcompat-libs; enough has landed for us to already roll this out. |
removing from P-backcompat-libs (since the back compat stuff is done). P-high. |
ping from triage |
This is close enough to done that we are going to close it -- the two remaining issues can be resolved independently. |
internal: Make `CfgExpr` slimmer
internal: Make `CfgExpr` slimmer
Tracking rust-lang/rfcs#135.
Task list:
The text was updated successfully, but these errors were encountered: