Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove ty_nil and replace with zero-length tuple #18614

Closed
nikomatsakis opened this issue Nov 4, 2014 · 3 comments · Fixed by #18752
Closed

Remove ty_nil and replace with zero-length tuple #18614

nikomatsakis opened this issue Nov 4, 2014 · 3 comments · Fixed by #18752
Labels
A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@nikomatsakis
Copy link
Contributor

Distinguishing zero-arity tuples as nil causes annoying discontinuities in the compiler. We should remove ty_nil and just use ty_tup with a zero-length list of types. I tried to do this, though, and encountered errors in the exhaustiveness checker that I did not understand.
@nikomatsakis nikomatsakis added A-an-interesting-project A-type-system Area: Type system E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Nov 4, 2014
@nikomatsakis
Copy link
Contributor Author

I'm happy to mentor this project.

@ghost ghost mentioned this issue Nov 4, 2014
Closed
@nikomatsakis nikomatsakis mentioned this issue Nov 4, 2014
Closed
@ghost
Copy link

ghost commented Nov 4, 2014

Given that you encountered roadblocks in match exhaustiveness, I can take a look.

@nikomatsakis
Copy link
Contributor Author

On Tue, Nov 04, 2014 at 12:38:06PM -0800, Jakub wrote:

Given that you encountered roadblocks in match exhaustiveness, I can take a look.

Thanks. I meant to ping you about that.

@ghost ghost self-assigned this Nov 4, 2014
@ghost ghost mentioned this issue Nov 7, 2014
Merged
bors added a commit that referenced this issue Nov 11, 2014
@bors
auto merge of #18752 : jakub-/rust/remove-unit, r=eddyb
f2a1efe 
Closes #18614.
bors added a commit that referenced this issue Nov 15, 2014
@bors
auto merge of #18752 : jakub-/rust/remove-unit, r=eddyb
9cf22ab 
Closes #18614.
bors added a commit that referenced this issue Nov 16, 2014
@bors
auto merge of #18752 : jakub-/rust/remove-unit, r=eddyb
321488b 
Closes #18614.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-type-system Area: Type system C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unit
1 participant
@nikomatsakis