Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Un-feature-gate struct variants #18641

Closed
alexcrichton opened this issue Nov 5, 2014 · 0 comments · Fixed by #18994
Closed

Un-feature-gate struct variants #18641

alexcrichton opened this issue Nov 5, 2014 · 0 comments · Fixed by #18994
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.

Comments

@alexcrichton
Copy link
Member

... and also tweak the visibility of fields slightly.

Tracking issue for rust-lang/rfcs#418
@alexcrichton alexcrichton added the B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. label Nov 5, 2014
@alexcrichton alexcrichton mentioned this issue Nov 5, 2014
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this issue Nov 6, 2014
@steveklabnik
Remove struct_variant feature gate.
f375d5d 
Closes rust-lang#18641
@sfackler sfackler mentioned this issue Nov 16, 2014
Merged
sfackler added a commit to sfackler/rust that referenced this issue Nov 16, 2014
@sfackler
Un-feature gate struct variants
579c65d 
Struct variant field visibility is now inherited. Remove `pub` keywords
from declarations.

Closes rust-lang#18641

[breaking-change]
bors added a commit that referenced this issue Nov 16, 2014
@bors
auto merge of #18994 : sfackler/rust/struct-variants-pt2, r=jakub-
aad7547 
Struct variant field visibility is now inherited. Remove `pub` keywords
from declarations.

Closes #18641

[breaking-change]

r? @alexcrichton
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Un-feature gate struct variants sfackler/rust
1 participant
@alexcrichton