Skip to content

Stop running tidy on the test suite #2271

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
marijnh opened this issue Apr 23, 2012 · 5 comments
Closed

Stop running tidy on the test suite #2271

marijnh opened this issue Apr 23, 2012 · 5 comments
Assignees
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Milestone

Comments

@marijnh
Copy link
Contributor

marijnh commented Apr 23, 2012

Having the build fail because a test includes a long line seems a bad use of everybody's time.

@nikomatsakis
Copy link
Contributor

I am inclined to agree, though the last time I proposed it @brson was
opposed. I did make it so that lines which include "//!" are exempted,
allowing you to include long expected error messages.

@brson
Copy link
Contributor

brson commented Apr 24, 2012

I am in favor now. Probably should convince graydon too. Lets remember to remove the special case from the tidy script.

@ghost ghost assigned brson Apr 26, 2012
@catamorphism
Copy link
Contributor

I'm in favor.

@brson
Copy link
Contributor

brson commented Apr 26, 2012

@graydon do you have an opinion?

@brson brson closed this as completed in 3038502 Apr 30, 2012
@brson
Copy link
Contributor

brson commented Apr 30, 2012

Done.

celinval pushed a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
jieyouxu added a commit to jieyouxu/rust that referenced this issue Mar 11, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

4 participants