-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Calling native functions that take enums by value is broken #2334
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
A-codegen
Area: Code generation
Comments
Can we check to see if this is still broken? |
(That test is now in |
My guess is that one of the patches @nikomatsakis landed such as efc7f82 may have fixed this. I'm not sure it's fixed but we can certainly generate code for it now. @brson : do you remember how it was broken? did it just not compile, or crash, or .. ? |
(I just tested it and it compiles and runs on windows) |
Filed #8173 to close this. |
graydon
added a commit
to graydon/rust
that referenced
this issue
Aug 14, 2013
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Sep 22, 2022
we don't need HexRange any more
celinval
pushed a commit
to celinval/rust-dev
that referenced
this issue
Jun 4, 2024
This test is flaky in CI; removing until we can diagnose and fix the failure.
tshepang
pushed a commit
to tshepang/rust
that referenced
this issue
Apr 19, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Since switching to named structs for enums we can no longer generate code for native functions that take by-val enums because we don't handle the LLVM array type correctly in native.rs. I added some hacks to get servo building again (which uses the c_void type in some signatures), but there is a big FIXME in native.rs that says "I HAVE NO IDEA WHAT I AM DOING THIS MUST BE WRONG" in
fn classify
, and run-pass/native-struct is xfailed on win32.The text was updated successfully, but these errors were encountered: