-
Notifications
You must be signed in to change notification settings - Fork 13.4k
std::os::windows::io::RawHandle
exposes libc::HANDLE
#24450
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I think that rust-lang/rfcs#1044 will fix this as it sets a vision for "raw" types and where they're defined and/or organized. In this case they'll be defined in the |
I'd be happy with just having |
[WIP] Fix #215 - Remove quack library usage Not currently working, but progress has been made: * cargo update * flate (deprecated) -> flate2 * os::MemoryMap -> mmap * rustc-serialize 0.2.8 -> 0.3.x * range(a, b) -> a..b * old_io -> io * Other misc changes. Add Mapper associated type. Latest Changes. Revert some trait changes. This removes some of the changes I made while trying to understand what was going on. In its current form, the code is certianly *not* correct, but it's more correct than it was (BlockStates<R> vs BlockStates for example). Fix misc errors Thanks @eddyb! Fix AsRawFd, WindowSettings builder pattern. Fix window use. Fix pub/mut in several places. Add NbtReaderError type for NbtReader to simplify errorr handling. Fix all warnings and errors Make changes as suggested by @eddyb Linux build works now. Fix Windows build. Changes to the retep998 branch of mmap and adds libc from crates.io to deal with rust-lang/rust#24450. Change Frame -> Output Remove assets zip (oops) Remove superfluous map.
This is fixed: liblibc doesn't have |
std::os::windows::io::RawHandle
is a re-export oflibc::HANDLE = *mut libc::c_void
, andc_void
is defined as enum.So it's possible to access non-primitive type of liblibc via
std
. This leads to confusing error if someone uses bothRawHandle
and crates.io's liblibc:(On unix,
std::os::unix::io::RawFd
is re-export oflibc::c_int
, which is re-export of primitive type.)The text was updated successfully, but these errors were encountered: