Skip to content

Provide a function to write the standard ebml header #2741

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
catamorphism opened this issue Jun 28, 2012 · 5 comments · Fixed by #22161
Closed

Provide a function to write the standard ebml header #2741

catamorphism opened this issue Jun 28, 2012 · 5 comments · Fixed by #22161
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@catamorphism
Copy link
Contributor

as per FIXME in std::ebml.
@metajack
Copy link
Contributor

metajack commented May 2, 2013

Would this be the "EBML Basics" defined here? http://ebml.sourceforge.net/specs/

I don't see anything about "standard header" in the specs here, so I figured I'd ask for clarification.

@emberian
Copy link
Member

Visiting for triage. FIXME is still there but I have no idea what the standard header should be either.

@huonw
Copy link
Member

huonw commented Sep 10, 2013

Triage: FIXME is still there; is the "standard header" the EBML Basics section of the Element Semantics table of @metajack's link?

@emberian
Copy link
Member

See also #9303, which will obviate this (since it will now be our own datatype, it will probably see a revamp and not have and weirdness like this)

@emberian
Copy link
Member

http://matroska.org/technical/specs/rfc/index.html, see section 5. This defines what we probably should be doing here.

steveklabnik added a commit to steveklabnik/rust that referenced this issue Feb 11, 2015
@steveklabnik
Remove FIXME in librbml
07f1d3d 
Given that this is entirely internal, this enhancement isn't going to be needed. And if it is, we'll add it.

Closes rust-lang#2741.
@steveklabnik steveklabnik mentioned this issue Feb 11, 2015
Merged
richo added a commit to richo/rust that referenced this issue Feb 11, 2015
@richo
Rollup merge of rust-lang#22161 - steveklabnik:close_2741, r=alexcric…
af6d6ae 
…hton

Given that this is entirely internal, this enhancement isn't going to be needed. And if it is, we'll add it.

Closes rust-lang#2741.
alexcrichton added a commit to alexcrichton/rust that referenced this issue Feb 11, 2015
@alexcrichton
rollup merge of rust-lang#22161: steveklabnik/close_2741
92e7aeb 
Given that this is entirely internal, this enhancement isn't going to be needed. And if it is, we'll add it.

Closes rust-lang#2741.
RalfJung pushed a commit to RalfJung/rust that referenced this issue Dec 28, 2022
@bors
Auto merge of rust-lang#2741 - RalfJung:filenames, r=RalfJung
ca1e861 
cargo-miri: use rustc to determine the output filename

This should fix rust-lang/miri#2740 and fix rust-lang/miri#1867: we no longer need to hard-code the file name logic in cargo-miri.
Aaron1011 pushed a commit to Aaron1011/rust that referenced this issue Jan 6, 2023
@bors
Auto merge of rust-lang#2741 - RalfJung:filenames, r=RalfJung
9f316ae 
cargo-miri: use rustc to determine the output filename

This should fix rust-lang/miri#2740 and fix rust-lang/miri#1867: we no longer need to hard-code the file name logic in cargo-miri.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove FIXME in librbml steveklabnik/rust
4 participants
@metajack @catamorphism @emberian @huonw