Tracking issue for VecDeque Extras #27788

Gankra · 2015-08-13T01:37:30Z

This covers the deque_extras blanket feature, which should probably be sharded more in the future. It covers:

truncate
resize
as_slices
as_mut_slices
swap_back_remove
swap_front_remove

Some notes:

truncate and resize are strange because they aren't directional (they just truncate off the back). Need work.
as_slices and as_mut_slices seem good to go. A bit niche, but so is VecDeque. Maybe move the mut to the end. RFC'd and everything.
swap_back_remove and swap_front_remove also seem good to go. Maybe move the directional specifier to the end. RFC'd and everything.

The text was updated successfully, but these errors were encountered:

eefriedman · 2015-09-02T00:22:09Z

shrink_to_fit and insert are now also part of deque_extras.

sfackler · 2015-09-17T06:22:56Z

I think we can pretty easily stabilize as_slices and as_mut_slices. Not sure about the others.

alexcrichton · 2015-09-24T15:28:13Z

This issue is now entering its cycle-long FCP for stabilization in 1.5

Specifically the as_slices and as_mut_slices along swap_*_remove methods are being considered for stabilization. We are also considering renaming the swapping methods.

llogiq · 2015-10-21T04:40:13Z

@alexcrichton How should the swapping methods be named?

alexcrichton · 2015-10-21T16:17:19Z

@llogiq as mentioned in the issue description, the other candidate names would be swap_remove_back and swap_remove_front

alexcrichton · 2015-10-22T00:09:56Z

The libs team discussed this during triage today and the decision was to stabilize:

insert
shrink_to_fit
as_slices
as_mut_slices
swap_remove_front (renamed from swap_front_remove)
swap_remove_back (renamed from swap_back_remove)

Gankra · 2015-10-22T13:29:47Z

Oh, we forgot to discuss as_mut_slices vs as_slices_mut.

I think we should move muts to the back as much as possible, even if in this case we're making "mutable slices", it's still the _mut variant of as_slices.

alexcrichton · 2015-10-22T15:18:29Z

Hm I'm not sure I'd follow the same reasoning, in method names types like &mut [T] and *mut T are referred to as mut_slice and mut_ptr. We've always known about this with regards to the _mut-at-the-end convention, so I would feel that these methods are correctly named.

Gankra · 2015-10-22T15:27:14Z

Yeah I've been a bit ambivalent about that naming scheme, but I guess it's
a bit too late for that!

On Thu, Oct 22, 2015 at 11:18 AM, Alex Crichton notifications@github.com
wrote:

Hm I'm not sure I'd follow the same reasoning, in method names types like &mut
[T] and *mut T are referred to as mut_slice and mut_ptr. We've always
known about this with regards to the _mut-at-the-end convention, so I
would feel that these methods are correctly named.

—
Reply to this email directly or view it on GitHub
#27788 (comment).

This commit stabilizes and deprecates library APIs whose FCP has closed in the last cycle, specifically: Stabilized APIs: * `fs::canonicalize` * `Path::{metadata, symlink_metadata, canonicalize, read_link, read_dir, exists, is_file, is_dir}` - all moved to inherent methods from the `PathExt` trait. * `Formatter::fill` * `Formatter::width` * `Formatter::precision` * `Formatter::sign_plus` * `Formatter::sign_minus` * `Formatter::alternate` * `Formatter::sign_aware_zero_pad` * `string::ParseError` * `Utf8Error::valid_up_to` * `Iterator::{cmp, partial_cmp, eq, ne, lt, le, gt, ge}` * `<[T]>::split_{first,last}{,_mut}` * `Condvar::wait_timeout` - note that `wait_timeout_ms` is not yet deprecated but will be once 1.5 is released. * `str::{R,}MatchIndices` * `str::{r,}match_indices` * `char::from_u32_unchecked` * `VecDeque::insert` * `VecDeque::shrink_to_fit` * `VecDeque::as_slices` * `VecDeque::as_mut_slices` * `VecDeque::swap_remove_front` - (renamed from `swap_front_remove`) * `VecDeque::swap_remove_back` - (renamed from `swap_back_remove`) * `Vec::resize` * `str::slice_mut_unchecked` * `FileTypeExt` * `FileTypeExt::{is_block_device, is_char_device, is_fifo, is_socket}` * `BinaryHeap::from` - `from_vec` deprecated in favor of this * `BinaryHeap::into_vec` - plus a `Into` impl * `BinaryHeap::into_sorted_vec` Deprecated APIs * `slice::ref_slice` * `slice::mut_ref_slice` * `iter::{range_inclusive, RangeInclusive}` * `std::dynamic_lib` Closes rust-lang#27706 Closes rust-lang#27725 cc rust-lang#27726 (align not stabilized yet) Closes rust-lang#27734 Closes rust-lang#27737 Closes rust-lang#27742 Closes rust-lang#27743 Closes rust-lang#27772 Closes rust-lang#27774 Closes rust-lang#27777 Closes rust-lang#27781 cc rust-lang#27788 (a few remaining methods though) Closes rust-lang#27790 Closes rust-lang#27793 Closes rust-lang#27796 Closes rust-lang#27810 cc rust-lang#28147 (not all parts stabilized)

This commit stabilizes and deprecates library APIs whose FCP has closed in the last cycle, specifically: Stabilized APIs: * `fs::canonicalize` * `Path::{metadata, symlink_metadata, canonicalize, read_link, read_dir, exists, is_file, is_dir}` - all moved to inherent methods from the `PathExt` trait. * `Formatter::fill` * `Formatter::width` * `Formatter::precision` * `Formatter::sign_plus` * `Formatter::sign_minus` * `Formatter::alternate` * `Formatter::sign_aware_zero_pad` * `string::ParseError` * `Utf8Error::valid_up_to` * `Iterator::{cmp, partial_cmp, eq, ne, lt, le, gt, ge}` * `<[T]>::split_{first,last}{,_mut}` * `Condvar::wait_timeout` - note that `wait_timeout_ms` is not yet deprecated but will be once 1.5 is released. * `str::{R,}MatchIndices` * `str::{r,}match_indices` * `char::from_u32_unchecked` * `VecDeque::insert` * `VecDeque::shrink_to_fit` * `VecDeque::as_slices` * `VecDeque::as_mut_slices` * `VecDeque::swap_remove_front` - (renamed from `swap_front_remove`) * `VecDeque::swap_remove_back` - (renamed from `swap_back_remove`) * `Vec::resize` * `str::slice_mut_unchecked` * `FileTypeExt` * `FileTypeExt::{is_block_device, is_char_device, is_fifo, is_socket}` * `BinaryHeap::from` - `from_vec` deprecated in favor of this * `BinaryHeap::into_vec` - plus a `Into` impl * `BinaryHeap::into_sorted_vec` Deprecated APIs * `slice::ref_slice` * `slice::mut_ref_slice` * `iter::{range_inclusive, RangeInclusive}` * `std::dynamic_lib` Closes #27706 Closes #27725 cc #27726 (align not stabilized yet) Closes #27734 Closes #27737 Closes #27742 Closes #27743 Closes #27772 Closes #27774 Closes #27777 Closes #27781 cc #27788 (a few remaining methods though) Closes #27790 Closes #27793 Closes #27796 Closes #27810 cc #28147 (not all parts stabilized)

sfackler · 2017-01-19T09:11:59Z

The only remaining unstable methods on VecDeque are truncate and resize. Nominating to stabilize.

@rfcbot fcp merge

rfcbot · 2017-01-19T09:17:42Z

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2017-01-23T22:44:19Z

🔔 This is now entering its final comment period, as per the review above. 🔔

This commit applies the stabilization/deprecations of the 1.16.0 release, as tracked by the rust-lang/rust issue tracker and the final-comment-period tag. The following APIs were stabilized: * `VecDeque::truncate` * `VecDeque::resize` * `String::insert_str` * `Duration::checked_{add,sub,div,mul}` * `str::replacen` * `SocketAddr::is_ipv{4,6}` * `IpAddr::is_ipv{4,6}` * `str::repeat` * `Vec::dedup_by` * `Vec::dedup_by_key` * `Result::unwrap_or_default` * `<*const T>::wrapping_offset` * `<*mut T>::wrapping_offset` * `CommandExt::creation_flags` (on Windows) * `File::set_permissions` * `String::split_off` The following APIs were deprecated * `EnumSet` - replaced with other ecosystem abstractions, long since unstable Closes rust-lang#27788 Closes rust-lang#35553 Closes rust-lang#35774 Closes rust-lang#36436 Closes rust-lang#36949 Closes rust-lang#37079 Closes rust-lang#37087 Closes rust-lang#37516 Closes rust-lang#37827 Closes rust-lang#37916 Closes rust-lang#37966 Closes rust-lang#38080

std: Stabilize APIs for the 1.16.0 release This commit applies the stabilization/deprecations of the 1.16.0 release, as tracked by the rust-lang/rust issue tracker and the final-comment-period tag. The following APIs were stabilized: * `VecDeque::truncate` * `VecDeque::resize` * `String::insert_str` * `Duration::checked_{add,sub,div,mul}` * `str::replacen` * `SocketAddr::is_ipv{4,6}` * `IpAddr::is_ipv{4,6}` * `str::repeat` * `Vec::dedup_by` * `Vec::dedup_by_key` * `Result::unwrap_or_default` * `<*const T>::wrapping_offset` * `<*mut T>::wrapping_offset` * `CommandExt::creation_flags` (on Windows) * `File::set_permissions` * `String::split_off` The following APIs were deprecated * `EnumSet` - replaced with other ecosystem abstractions, long since unstable Closes rust-lang#27788 Closes rust-lang#35553 Closes rust-lang#35774 Closes rust-lang#36436 Closes rust-lang#36949 Closes rust-lang#37079 Closes rust-lang#37087 Closes rust-lang#37516 Closes rust-lang#37827 Closes rust-lang#37916 Closes rust-lang#37966 Closes rust-lang#38080

Gankra added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label Aug 13, 2015

aturon added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 13, 2015

sfackler added the I-nominated label Sep 17, 2015

alexcrichton added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed I-nominated labels Sep 24, 2015

steveklabnik added this to the 1.5 milestone Oct 1, 2015

alexcrichton mentioned this issue Oct 23, 2015

std: Stabilize library APIs for 1.5 #29254

Merged

alexcrichton removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Nov 5, 2015

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jan 23, 2017

alexcrichton mentioned this issue Jan 26, 2017

std: Stabilize APIs for the 1.16.0 release #39307

Merged

bors closed this as completed in #39307 Jan 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tracking issue for VecDeque Extras #27788

Tracking issue for VecDeque Extras #27788

Gankra commented Aug 13, 2015

eefriedman commented Sep 2, 2015

sfackler commented Sep 17, 2015

alexcrichton commented Sep 24, 2015

llogiq commented Oct 21, 2015

alexcrichton commented Oct 21, 2015

alexcrichton commented Oct 22, 2015

Gankra commented Oct 22, 2015

alexcrichton commented Oct 22, 2015

Gankra commented Oct 22, 2015

sfackler commented Jan 19, 2017

rfcbot commented Jan 19, 2017 •

edited by Kimundi

Loading

rfcbot commented Jan 23, 2017

Tracking issue for VecDeque Extras #27788

Tracking issue for VecDeque Extras #27788

Comments

Gankra commented Aug 13, 2015

eefriedman commented Sep 2, 2015

sfackler commented Sep 17, 2015

alexcrichton commented Sep 24, 2015

llogiq commented Oct 21, 2015

alexcrichton commented Oct 21, 2015

alexcrichton commented Oct 22, 2015

Gankra commented Oct 22, 2015

alexcrichton commented Oct 22, 2015

Gankra commented Oct 22, 2015

sfackler commented Jan 19, 2017

rfcbot commented Jan 19, 2017 • edited by Kimundi Loading

rfcbot commented Jan 23, 2017

rfcbot commented Jan 19, 2017 •

edited by Kimundi

Loading