Compiler must show real line in failed test

[KalitaAlexey]

Currently if some test fails then compiler shows error with relative position <anon>:21:5. This is very uncomfortable

[apasel422]

Could you provide some more information or some example code / steps to reproduce this?

[KalitaAlexey]

Any test, any syntax error or assert shows positition relative to test begin

[apasel422]

Are you talking about the tests that are run by make check, #[test] functions in user code run through e.g. cargo test, or something else?

[KalitaAlexey]

I mean documentation test running through cargo test

[apasel422]

OK, so to elaborate, the issue here is that doc test failures don't include the name of the file that contains the doc test. This is a result of how rustdoc works, which is by passing the source code of the test, as extracted from the comment in the file, to rustc via stdin. We can probably add an unstable command-line argument to rustc that allows a file name to be specified in such scenarios and amend rustdoc to use it.

[KalitaAlexey]

Do something, please.

[apasel422]

I'm investigating implementing this now.

[apasel422]

This doesn't actually need a command-line option added to rustc, as rustdoc calls driver::compile_input directly, making this change simpler.

[steveklabnik]

Do something, please.

Please try to recognize that this is an open source project, and many people are working in their spare time. Specifically, as far as I know, @apasel422 is not paid to work on Rust. While we want Rust to be great for everyone, the reality is that there are thousands of open bugs, and so some of them will take time to address.

[KalitaAlexey]

@steveklabnik Do you want me to do that? Could you aim me to this? Should I examine cargo sources?

[apasel422]

@KalitaAlexey If you're interested in implementing this yourself (I don't know when I'll be able to complete it), the general idea would be augmenting rustc::session::config::Input::String with an Option<PathBuf> or perhaps Option<String> that carries a "secondary" filename that will be used in rustdoc.

[mitaa]

Thanks @apasel422, I've implemented the filename part here, but it turns out that solving the issue with line numbers being relative to the start of the codeblock instead of to the start of the file is kind of infeasible to solve (which is AIUI the main request from @KalitaAlexey).

The current <anon> is I think preferable to showing the correct filename with wrong line numbers.

[GuillaumeGomez]

I think we can close it? Just reopen it if you feel something is missing.