Later duplicate attributes, e.g. #[ignore(cfg(windows))] #[ignore], are silently ignored

[bblum]

I'd marked a test case with those two attributes, intended to remove the second one later, but the compiler didn't bother with the second one to begin with. This caused a known-buggy test case to run anyway and wedge the build bots on all but windows.

I would have liked to have seen something like warning: duplicate ignore attribute; ignoring the latter

[pcwalton]

I don't believe this is backwards incompatible.

[graydon]

bug in #[ignore] in particular, might be more widespread

[nikomatsakis]

What you really want is the union of all ignores, right?

And possibly a warning if you have a #[ignore] and a #[ignore(...)].

[graydon]

this shouldn't warn, it should just do the right thing

[graydon]

accepted for backwards-compatible milestone

[pcwalton]

This was fixed by @luqmana's change. Yay!