Skip to content

Remove iter::timesi #3130

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
brson opened this issue Aug 7, 2012 · 4 comments
Closed

Remove iter::timesi #3130

brson opened this issue Aug 7, 2012 · 4 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.5

Comments

@brson
Copy link
Contributor

brson commented Aug 7, 2012

Most people would rather have a .to method (and trait presumably) for Ord types and a range function that (probably) uses that method.
@vertexclique vertexclique mentioned this issue Oct 28, 2012
Merged
@bstrie
Copy link
Contributor

bstrie commented Oct 29, 2012

Glad to see timesi go, it is an abomination.

One more small thing: a .to method is ambiguously named. Does do 1.to(10) include or exclude 10? In colloquial usage "to" is inclusive ("on a scale of 1 to 10"), but the method it's replacing is exclusive. .until would be a more appropriate name.

@brson
Copy link
Contributor Author

brson commented Oct 29, 2012

For the record, I don't love the .to method anymore either. range is fine.

@bstrie
Copy link
Contributor

bstrie commented Oct 29, 2012

While I don't love range because the Python in me insists that it's returning an array, I can live with it as long as there's a generic function somewhere on all Ord types.

@burg
Copy link

burg commented Nov 5, 2012

This issue is resolved by the above pull request.

bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@nrc
Merge pull request rust-lang#3130 from JoshBrudnak/master
4789f65 
Added crates to the non-alphabetical treated imports
RalfJung pushed a commit to RalfJung/rust that referenced this issue Oct 21, 2023
@bors
Auto merge of rust-lang#3130 - RalfJung:rustup, r=RalfJung
5d62040 
Rustup
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval
Upgrade toolchain to nightly-2024-04-15 (rust-lang#3144)
b9bd7a8 
Related changes:
  - rust-lang#118310:
    Add `Ord::cmp` for primitives as a `BinOp` in MIR
  - rust-lang#120131:
    Add support to `Pat` pattern type
  - rust-lang#122935:
    Rename CastKind::PointerWithExposedProvenance
  - rust-lang#123097:
    Adapt to changes to local_def_path_hash_to_def_id

Resolves rust-lang#3130, rust-lang#3142
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
4 participants
@burg @brson @catamorphism @bstrie