-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Improve name resolution failure detection #32119
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
A-resolve
Area: Name/path resolution done by `rustc_resolve` specifically
Comments
This a violation of the first coherence condition from this comment. |
jseyfried
added a commit
to jseyfried/rust
that referenced
this issue
Mar 27, 2016
jseyfried
added a commit
to jseyfried/rust
that referenced
this issue
Mar 27, 2016
bors
added a commit
that referenced
this issue
Apr 5, 2016
resolve: Improve import failure detection and lay groundwork for RFC 1422 This PR improves import failure detection and lays some groundwork for RFC 1422. More specifically, it - Avoids recomputing the resolution of an import directive's module path. - Refactors code in `resolve_imports` that does not scale to the arbitrarily many levels of visibility that will be required by RFC 1422. - Replaces `ModuleS`'s fields `public_glob_count`, `private_glob_count`, and `resolved_globs` with a list of glob import directives `globs`. - Replaces `NameResolution`'s fields `pub_outstanding_references` and `outstanding_references` with a field `single_imports` of a newly defined type `SingleImports`. - Improves import failure detection by detecting cycles that include single imports (currently, only cycles of globs are detected). This fixes #32119. r? @nikomatsakis
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Right now, this compiles ...
Neither case compiled before #31726, when even this would not compile:
The text was updated successfully, but these errors were encountered: