-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bison grammar is outdated #32723
Comments
Well, one question is, should the grammar show nightly-only things. If so, it would not include @nikomatsakis has been working on a larlpop grammar that would hopefully make this stuff easier... |
cc #15880, a bot which is intended to run these tests |
I don't think we have a bison grammar in-tree anymore... @nikomatsakis @steveklabnik @alexcrichton Do you know of the current state of the in-tree grammar? Do we want to show nightly-only things in the grammar? |
Oh I have no idea what's up with the current in-tree grammar, I would expect it to be quite out of date at this point. |
Yeah, it's basically abandonware. Niko had some efforts to have a real one, but I assume anything we do have is horribly bit-rotted. |
Do we want to try and get some movement from the community on implementing a reference grammar? Is it something we're interested in maintaining? If not, we should probably go ahead and close out issues relevant to the reference grammar; if yes, arguably closing the issues in favor of a thread on internals would still be a good idea. |
I would go this route, but let's hear what @nikomatsakis has to say |
Traige: There is ongoing work (as of about two weeks ago) on creating an up-to-date grammar in the reference (rust-lang/reference#84); generally, this issue seems to under #30942 when it comes to a machine-readable grammar, and the reference issue when it comes to just having some up-to-date grammar. |
Update grammar to parse current rust syntax Mainly addressing rust-lang#32723. This PR updates the bison grammar so that it can parse the current rust syntax, except for feature-gated syntax additions. It has been tested with all the tests in run-pass. The grammar in this repo doesn't have build logic anymore, but you can test it out in https://github.com/bleibig/rust-grammar, which has all of what's in this PR. If you are interested in having build logic and grammar tests again, I can look into implementing that as well. I'm aware that things are somewhat undecided as to what an official rust grammar should be from the discussion in rust-lang#30942. With this PR we can go back to having an up-to-date flex/bison based grammar, but the rustypop grammar looks interesting as well.
Triage: there's a new grammar wg, and i don't even think the bison grammar still exists. closing as outdated. |
I still see |
After posting that comment, I checked it out again and saw that it was still there, which led to #55545 |
It looks like grammar (https://github.com/rust-lang/rust/tree/master/src/grammar) is outdated, for example '?' shortcut for try! is not supported.
The text was updated successfully, but these errors were encountered: