-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Panic in librbml while drunk-compiling #33015
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Couldn't reproduce: next time I compiled, I just got a compile error in a different part of the compiled code. Just thought I would raise a ticket anyway because it should probably not have panicked the first time. Lesson for future generations of rustaceans: don't compile code on friday pub night when drunk: It's bad for your health! |
You have a curious idea of a night out! |
I think someone is doing error recovery for "error: the crate "bitflags" has been comp |
@pierrechevalier83 Something was very strange in your original description, I tried to clean up the markdown to make it easier to read. |
Problem lines of code: rust/src/libsyntax/errors/mod.rs Line 209 in 2a815a2
pub fn emit(&mut self) {
if self.cancelled() {
return;
}
self.emitter.borrow_mut().emit_struct(&self);
self.cancel();
// if self.is_fatal() {
// panic!(FatalError);
// }
} Why is the panic commented? cc @nrc |
That seems like it should be uncommented. It's a mistake either way, I wouldn't deliberately check-in commented code, but I don't recall if it should be uncommented or just not there. It does seem like we should panic on fatal errors. |
triage: P-medium |
The ghost seems to be back, I'm getting this error when compiling RustAudio/synth on Windows. I'll try to get rustc compiled from source to debug this. |
@filmor Did you update your Rust version yet there are |
Not that I'm aware, this is a fresh build with a newly rustupped rustc. To be sure I cleaned up |
…sion check the metadata lock when loading rather than afterwards Fixes rust-lang#33733 Fixes rust-lang#33015
Uh oh!
There was an error while loading. Please reload this page.
The text was updated successfully, but these errors were encountered: