Skip to content

Panic in librbml while drunk-compiling #33015

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
pierrechevalier83 opened this issue Apr 15, 2016 · 10 comments
Closed

Panic in librbml while drunk-compiling #33015

pierrechevalier83 opened this issue Apr 15, 2016 · 10 comments
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@pierrechevalier83
Copy link

pierrechevalier83 commented Apr 15, 2016

   Compiling pistoncore-input v0.9.0
/home/pierrec/.cargo/registry/src/github.heygears.com-88ac128001ac3a9a/pistoncore-input-0.9.0/src/lib.rs:9:1: 9:23 error: the crate "bitflags" has been compiled with rustc 1.7.0, which is incompatible with this version of rustc [E0514]
/home/pierrec/.cargo/registry/src/github.heygears.com-88ac128001ac3a9a/pistoncore-input-0.9.0/src/lib.rs:9 extern crate bitflags;
                                                                                                  ^~~~~~~~~~~~~~~~~~~~~~
/home/pierrec/.cargo/registry/src/github.heygears.com-88ac128001ac3a9a/pistoncore-input-0.9.0/src/lib.rs:9:1: 9:23 help: consider removing the compiled binaries and recompiling with your current version of rustc
ERROR:rbml::reader: failed to find block with tag 275
error: internal compiler error: unexpected panic
note: the compiler unexpectedly panicked. this is a bug.
note: we would appreciate a bug report: https://github.com/rustlang/rust/blob/master/CONTRIBUTING.md#bug-reports
thread 'rustc' panicked at 'explicit panic', ../src/librbml/lib.rs:436
note: Run with "RUST_BACKTRACE=1" for a backtrace.


Build failed, waiting for other jobs to finish...
Could not compile "pistoncore-input".
@pierrechevalier83
Copy link
Author

Couldn't reproduce: next time I compiled, I just got a compile error in a different part of the compiled code. Just thought I would raise a ticket anyway because it should probably not have panicked the first time.

Lesson for future generations of rustaceans: don't compile code on friday pub night when drunk: It's bad for your health!

@sanmai-NL
Copy link

You have a curious idea of a night out!

@arielb1
Copy link
Contributor

arielb1 commented Apr 16, 2016

I think someone is doing error recovery for "error: the crate "bitflags" has been comp
iled with rustc 1.7.0, which is incompatible with this version of rustc"

@eddyb
Copy link
Member

eddyb commented Apr 16, 2016

@pierrechevalier83 Something was very strange in your original description, I tried to clean up the markdown to make it easier to read.

@arielb1
Copy link
Contributor

arielb1 commented May 1, 2016

Problem lines of code:

// if self.is_fatal() {

    pub fn emit(&mut self) {
        if self.cancelled() {
            return;
        }

        self.emitter.borrow_mut().emit_struct(&self);
        self.cancel();

        // if self.is_fatal() {
        //     panic!(FatalError);
        // }
    }

Why is the panic commented? cc @nrc

@arielb1 arielb1 added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 1, 2016
@nrc
Copy link
Member

nrc commented May 1, 2016

That seems like it should be uncommented. It's a mistake either way, I wouldn't deliberately check-in commented code, but I don't recall if it should be uncommented or just not there. It does seem like we should panic on fatal errors.

@nikomatsakis
Copy link
Contributor

triage: P-medium

@filmor
Copy link

filmor commented Jun 7, 2016

The ghost seems to be back, I'm getting this error when compiling RustAudio/synth on Windows. I'll try to get rustc compiled from source to debug this.

@eddyb
Copy link
Member

eddyb commented Jun 7, 2016

@filmor Did you update your Rust version yet there are rlib files around that are older?

@filmor
Copy link

filmor commented Jun 7, 2016

Not that I'm aware, this is a fresh build with a newly rustupped rustc. To be sure I cleaned up .cargo and target and I'm still getting the error.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
P-medium Medium priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

9 participants