Skip to content

Time tests fail sporadically on Mac #3327

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
catamorphism opened this issue Aug 31, 2012 · 3 comments
Closed

Time tests fail sporadically on Mac #3327

catamorphism opened this issue Aug 31, 2012 · 3 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. O-macos Operating system: macOS
Milestone

Comments

@catamorphism
Copy link
Contributor

When running make check on my Mac, three tests in time::tests (test_at, test_ctime, and test_strftime) sometimes fail. Usually if I just run make check again, the tests pass.

@brson
Copy link
Contributor

brson commented Aug 31, 2012

my suspicion is that the calls to the C tzset function access the environment, which is especially racy on os x, causing bogosity.

@catamorphism
Copy link
Contributor Author

test_strptime is also failing now, possibly for the same reason (it also calls tzset).

erickt added a commit that referenced this issue Jan 24, 2013
erickt added a commit to erickt/rust that referenced this issue Jan 25, 2013
@catamorphism
Copy link
Contributor Author

Fixed by @erickt in 9898485

RalfJung pushed a commit to RalfJung/rust that referenced this issue Mar 3, 2024
…=RalfJung

tree borrows: add a test to sb_fails

This is something that happens in the wild (rust-lang#121626), so TB accepting this is good. Let's make sure we notice if this ever changes.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc I-crash Issue: The compiler crashes (SIGSEGV, SIGABRT, etc). Use I-ICE instead when the compiler panics. O-macos Operating system: macOS
Projects
None yet
Development

No branches or pull requests

2 participants