-
Notifications
You must be signed in to change notification settings - Fork 13.4k
E0057 needs to be updated to new format #35214
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I'm taking this one. |
@jonathandturner I think I've got most of this fix/working, but I'm having a problem fixing one of the unit test cases - issue-3044.rs. The other related test cases (issue-18819, issue-4935, method-call-err-msg, not-enough-arguments, overloaded-calls-bad and variadic-ffi-3) I was able to fix by following your blog guide. For some reason, issue-3044 is 'different' and I don't understand why. Not sure how to proceed... |
@paulfanelli - can you show the errors you get when you try to get issue-3044 to pass? |
@jonathandturner I think I fixed the problem. I'm now trying to get my code checked in and pushed to by fork. Having some ssh key/cert issues. I think once I do that, I can do a PR? |
I just submitted a PR, but not sure if I did it correctly. |
The note of #35290 and this one are printed by the same function, can I modify it to print the expected types directly in the label? I also did the bonus2 part for both E0060 and E0061. |
Freeing this one up as part of the final push for #35233. |
Actually, according to the comments in #35395 maybe this is already closed? @paulfanelli @jonathandturner , can you confirm? |
…llaumeGomez Better underline for E0057,E0060,E0061 Fix rust-lang#35214 Part of rust-lang#35233 r? @jonathandturner
Uh oh!
There was an error while loading. Please reload this page.
From: src/test/compile-fail/E0057.rs
Error E0057 needs a span_label, updating it from:
To:
Bonus 1: The note seems excessive. Check other E0057 errors. If it is not needed, remove the note.
Bonus 2: The span for the error could likely focus on the parameters rather than the whole call.
The text was updated successfully, but these errors were encountered: