-
Notifications
You must be signed in to change notification settings - Fork 13.4k
E0131 needs to be updated to new format #35257
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
I am working on this one. |
I need some help, I cannot get the label to display in the compilation error. I've asked around in #rust-internals, nobody answered apart from @TheZoq2 who seems to be experiencing the same problem and is looking for a solution too. |
@GuillaumeGomez You did? I thought you had taken E0132 instead.
|
@Limeth: Yes sorry, when I have read the description, I thought it was the one I did because they're very close. I updated my comment. |
@Limeth are you not seeing the messages show up next to the span? If so, can you try running your
I ran into the same issue - the new formatting and span labels aren't enabled by default yet. |
That made it work for me @birryree |
Yes, that was the reason. Thank you, @birryree! |
We've implemented essentially the same thing with @GuillaumeGomez in two separate PRs. I am now waiting for his PR to get merged, so we both can use the same implementation. |
@Limeth: It should be merged in no time. Just hold on a bit more! |
E0131 updated to new format Changes ``` error[E0131]: main function is not allowed to have type parameters --> src/test/compile-fail/E0131.rs:11:1 | 11 | fn main<T>() { //~ ERROR E0131 | ^ ``` to ``` error[E0131]: main function is not allowed to have type parameters --> src/test/compile-fail/E0131.rs:11:1 | 11 | fn main<T>() { //~ ERROR E0131 | ^^^ main cannot have type parameters ``` Fixes rust-lang#35257. Part of rust-lang#35233. r? @jonathandturner
E0131 updated to new format Changes ``` error[E0131]: main function is not allowed to have type parameters --> src/test/compile-fail/E0131.rs:11:1 | 11 | fn main<T>() { //~ ERROR E0131 | ^ ``` to ``` error[E0131]: main function is not allowed to have type parameters --> src/test/compile-fail/E0131.rs:11:1 | 11 | fn main<T>() { //~ ERROR E0131 | ^^^ main cannot have type parameters ``` Fixes rust-lang#35257. Part of rust-lang#35233. r? @jonathandturner
E0131 updated to new format Changes ``` error[E0131]: main function is not allowed to have type parameters --> src/test/compile-fail/E0131.rs:11:1 | 11 | fn main<T>() { //~ ERROR E0131 | ^ ``` to ``` error[E0131]: main function is not allowed to have type parameters --> src/test/compile-fail/E0131.rs:11:1 | 11 | fn main<T>() { //~ ERROR E0131 | ^^^ main cannot have type parameters ``` Fixes rust-lang#35257. Part of rust-lang#35233. r? @jonathandturner
From:
Error E0131 needs a span_label, updating it from:
To:
Bonus: underline the type parameters directly
The text was updated successfully, but these errors were encountered: