Skip to content

Introduce as_slice/as_mut_slice methods on std::vec::IntoIter struct. #35601

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
frewsxcv opened this issue Aug 11, 2016 · 6 comments
Closed

Introduce as_slice/as_mut_slice methods on std::vec::IntoIter struct. #35601

frewsxcv opened this issue Aug 11, 2016 · 6 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@frewsxcv
Copy link
Member

frewsxcv commented Aug 11, 2016 •
edited
Loading

Tracking issue for: #35447
@alexcrichton alexcrichton added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Aug 11, 2016
@SimonSapin
Copy link
Contributor

I’ve wanted to use this today, but I’ll probably have to change my code to work differently.

FCP to stabilize?

@SimonSapin
Copy link
Contributor

For context: this code is using vec::IntoIter<syn::TokenTree> as parser input.

For more context: I’m attempting to replace a compiler plugin (for a procedural expression-macro) by a build script that parses the source file for a Rust module with the syn crate, walks the AST to find invocations of this macro, and replace them with the expansion. Vec<TokenTree> is used to represent the "arguments" of a macro invocation.

@alexcrichton
Copy link
Member

@rfcbot fcp merge

Neat methods!

@rfcbot
Copy link
Collaborator

rfcbot commented Nov 1, 2016 •
edited
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot
Copy link
Collaborator

rfcbot commented Nov 12, 2016

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @alexcrichton, I wasn't able to add the final-comment-period label, please do so.

@alexcrichton alexcrichton added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Nov 12, 2016
@rfcbot
Copy link
Collaborator

rfcbot commented Nov 22, 2016

The final comment period is now complete.

@aturon aturon mentioned this issue Dec 14, 2016
Merged
bors added a commit that referenced this issue Dec 18, 2016
@bors
Auto merge of #38369 - aturon:stab-1.15, r=alexcrichton
1f965cc 
Library stabilizations/deprecations for 1.15 release

Stabilized:

- `std::iter::Iterator::{min_by, max_by}`
- `std::os::*::fs::FileExt`
- `std::sync::atomic::Atomic*::{get_mut, into_inner}`
- `std::vec::IntoIter::{as_slice, as_mut_slice}`
- `std::sync::mpsc::Receiver::try_iter`
- `std::os::unix::process::CommandExt::before_exec`
- `std::rc::Rc::{strong_count, weak_count}`
- `std::sync::Arc::{strong_count, weak_count}`
- `std::char::{encode_utf8, encode_utf16}`
- `std::cell::Ref::clone`
- `std::io::Take::into_inner`

Deprecated:

- `std::rc::Rc::{would_unwrap, is_unique}`
- `std::cell::RefCell::borrow_state`

Closes #23755
Closes #27733
Closes #27746
Closes #27784
Closes #28356
Closes #31398
Closes #34931
Closes #35601
Closes #35603
Closes #35918
Closes #36105
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @SimonSapin @frewsxcv @rfcbot