Skip to content

Rename str's trait "UniqueStr" to "Trimmable"? #3712

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
kud1ing opened this issue Oct 10, 2012 · 1 comment
Closed

Rename str's trait "UniqueStr" to "Trimmable"? #3712

kud1ing opened this issue Oct 10, 2012 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.5

Comments

@kud1ing
Copy link

kud1ing commented Oct 10, 2012

According to the Style guide, trait names should be verbs or verbers.
I have no idea what "unique string" means, nor how it is related to the declared "trim" functions.

Maybe rename it to "Trimmable"?
@vertexclique vertexclique mentioned this issue Oct 15, 2012
Closed
@kud1ing
Copy link
Author

kud1ing commented Oct 21, 2012

Fixed by 81e66ae
Thanks

@kud1ing kud1ing closed this as completed Oct 21, 2012
bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
@rchaser53 @topecongiro
fix to build with rustc 1.38.0-nightly (4560cb8 2019-07-28) (rust-lan…
fe05e88 
…g#3712)
RalfJung pushed a commit to RalfJung/rust that referenced this issue Jul 29, 2024
@bors
Auto merge of rust-lang#3763 - tiif:global-fd-id, r=oli-obk
adbb89e 
Insert FileDescription instead of FileDescriptor in ``insert_fd``

This PR moves the creation of ``FileDescriptor`` inside ``insert_fd``, and ``insert_fd`` now takes in ``FileDescription`` instead of ``FileDescriptor``.  This change is needed by rust-lang#3712.
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 18, 2024
@bors
Auto merge of rust-lang#3712 - tiif:feat/epoll, r=oli-obk
86783be 
Implement epoll shim

This PR:
- implemented non-blocking ``epoll`` for rust-lang#3448 . The design for this PR is documented in https://hackmd.io/`@tiif/SJatftrH0` .
- renamed FileDescriptor to FileDescriptionRef
- assigned an ID to every file description
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
1 participant
@kud1ing