-
Notifications
You must be signed in to change notification settings - Fork 13.4k
<$t:ty> falls victim to C++ >> ambiguity #37175
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@durka yeah, this is definitely possible to fix. The parser already splits the To fix this, we could to have the parser mutate the |
Fixed in #37208. |
…kens_in_macros, r=nrc macros: fix partially consumed tokens in macro matchers Fixes rust-lang#37175. This PR also avoids re-transcribing the tokens consumed by a matcher (and cloning the `TtReader` once per matcher), which improves expansion performance of the test case from rust-lang#34630 by ~8%. r? @nrc
…kens_in_macros, r=nrc macros: fix partially consumed tokens in macro matchers Fixes rust-lang#37175. This PR also avoids re-transcribing the tokens consumed by a matcher (and cloning the `TtReader` once per matcher), which improves expansion performance of the test case from rust-lang#34630 by ~8%. r? @nrc
Consider this macro:
Unfortunately it can't deal with a type that ends in
>
:Is it possible to fix this? It seems to me the macro parser should know it's parsing
$t:ty
and therefore>>
can't be valid, so it should be split into two tokens.cc @jseyfried
The text was updated successfully, but these errors were encountered: