Skip to content

Tracking issue for ptr::{read,write}_unaligned #37955

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
alexcrichton opened this issue Nov 23, 2016 · 12 comments
Closed

Tracking issue for ptr::{read,write}_unaligned #37955

alexcrichton opened this issue Nov 23, 2016 · 12 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

Tracking issue for rust-lang/rfcs#1725
@alexcrichton alexcrichton added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 23, 2016
@alexcrichton alexcrichton mentioned this issue Nov 23, 2016
Merged
@sfackler sfackler added B-unstable Blocker: Implemented in the nightly compiler and unstable. and removed B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Nov 24, 2016
@sfackler sfackler added B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. and removed B-unstable Blocker: Implemented in the nightly compiler and unstable. labels Dec 11, 2016
@sfackler sfackler mentioned this issue Dec 12, 2016
Merged
sfackler added a commit to sfackler/rust that referenced this issue Dec 13, 2016
@sfackler
Implement RFC rust-lang#1725
75fe727 
cc rust-lang#37955
bors added a commit that referenced this issue Dec 13, 2016
@bors
Auto merge of #38309 - sfackler:rfc-1725, r=alexcrichton
0d1b9f4 
Implement RFC #1725 (read_unaligned, write_unaligned)

cc #37955

r? @alexcrichton
@chriskrycho
Copy link
Contributor

Status check: it looks like this is implemented, behind a feature flag, and not-yet-documented?

@whitequark
Copy link
Member

This has documentation now. What's the requirement for stabilization?

@alexcrichton alexcrichton added B-unstable Blocker: Implemented in the nightly compiler and unstable. and removed B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Feb 8, 2017
@alexcrichton
Copy link
Member Author

Ah looks like this wasn't tagged B-unstable by accident which then fell under our radar. In that case...

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Feb 8, 2017 •
edited by brson
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@niconii
Copy link
Contributor

niconii commented Feb 11, 2017

The problem with ptr::write's docs mentioned in #39733 is true of ptr::write_unaligned's docs as well.

@rfcbot
Copy link
Collaborator

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

4 similar comments
@rfcbot
Copy link
Collaborator

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot
Copy link
Collaborator

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot
Copy link
Collaborator

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot
Copy link
Collaborator

rfcbot commented Feb 13, 2017

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Feb 13, 2017
@whitequark
Copy link
Member

@rfcbot calm down please

@rfcbot
Copy link
Collaborator

rfcbot commented Feb 23, 2017

The final comment period is now complete.

frewsxcv pushed a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@aturon
Stabilize ptr_unaligned feature, closes rust-lang#37955
f789955
alexcrichton pushed a commit to alexcrichton/rust that referenced this issue Mar 17, 2017
@aturon @alexcrichton
Stabilize ptr_unaligned feature, closes rust-lang#37955
ba0f045
@bors bors closed this as completed in d38ea8b Mar 19, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@whitequark @alexcrichton @sfackler @chriskrycho @niconii @rfcbot