Skip to content

incr.comp.: Edge to Krate depnode when building regex in debug mode #38222

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
michaelwoerister opened this issue Dec 7, 2016 · 4 comments
Closed

incr.comp.: Edge to Krate depnode when building regex in debug mode #38222

michaelwoerister opened this issue Dec 7, 2016 · 4 comments
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
Incremental compi...

Comments

@michaelwoerister
Copy link
Member

Occurs with regex 0.1.75 (ac9ced6). The Krate-edge leads to everything being re-compiled for any change. The edge does not occur when compiling with --release.
@michaelwoerister michaelwoerister added the A-incr-comp Area: Incremental compilation label Dec 7, 2016
@nikomatsakis nikomatsakis added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 7, 2016
@michaelwoerister
Copy link
Member Author

Occurs when compiling with -Cdebuginfo=1 but not with -Cdebuginfo=0.

@michaelwoerister
Copy link
Member Author

Does not occur in nightly-2016-11-29, so it must have been introduced recently. #37954 looks suspicious.

@michaelwoerister
Copy link
Member Author

Fails with nightly-2016-12-01.

@michaelwoerister
Copy link
Member Author

michaelwoerister commented Dec 7, 2016 •
edited
Loading

The regression introduced somewhere in this range: 1c44857...908dba0

@michaelwoerister michaelwoerister mentioned this issue Dec 9, 2016
Merged
bors added a commit that referenced this issue Dec 12, 2016
@bors
Auto merge of #38243 - michaelwoerister:fix-debuginfo-namespace-edge,…
6483bdd 
… r=nikomatsakis

incr.comp.: Avoid creating an edge to DepNode::Krate when generating debuginfo namespaces.

r? @nikomatsakis

Fixes #38222
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-incr-comp Area: Incremental compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
Incremental compilation beta
Development

No branches or pull requests
2 participants
@nikomatsakis @michaelwoerister