-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Extract libcore benchmarks to a separate crate #39484
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@phungleson yeah that should do the trick! I think that you can avoid a whole new directory even, but could have something like |
The same thing applies to libcollections, too: benchmarks should be moved into libcollectionsbench (or libcollections/bench). |
…hton Extract libcore benchmarks to a separate folder Fix rust-lang#39484 r? @alexcrichton since you seem to know about this :) Thanks!
I've recently been wondering what the reason behind that was. Any ideas? Any links to previous discussion? |
…hton Extract libcore benchmarks to a separate folder Fix rust-lang#39484 r? @alexcrichton since you seem to know about this :) Thanks!
…hton Extract libcore benchmarks to a separate folder Fix rust-lang#39484 r? @alexcrichton since you seem to know about this :) Thanks!
@est31 in general compiling libcore with --test literally is a huge PITA because there's so many intermixed types. The "foreign" libcore (one linked by libtest) duplicates the local libcore (the one being compiled with --test) and it's very difficult to keep the types straight, especially for standard traits. It ended up being easier to do everything out of the library |
@alexcrichton thanks! |
…lexcrichton Extract collections benchmarks to libcollections/bench Good suggestion from @stjepang rust-lang#39484 (comment) r? @alexcrichton
…lexcrichton Extract collections benchmarks to libcollections/bench Good suggestion from @stjepang rust-lang#39484 (comment) r? @alexcrichton
…lexcrichton Extract collections benchmarks to libcollections/bench Good suggestion from @stjepang rust-lang#39484 (comment) r? @alexcrichton
…lexcrichton Extract collections benchmarks to libcollections/bench Good suggestion from @stjepang rust-lang#39484 (comment) r? @alexcrichton
…lexcrichton Extract collections benchmarks to libcollections/bench Good suggestion from @stjepang rust-lang#39484 (comment) r? @alexcrichton
When looking though
libcore
I saw thishttps://github.com/rust-lang/rust/blob/master/src/libcore/Cargo.toml#L16-L19
So just want to check if the task is about:
libcorebench
insrc
#[bench]
fromlibcoretest
tolibcorebench
like this onehttps://github.com/rust-lang/rust/blob/master/src/libcoretest/any.rs#L128
If it is I can give it a try, thanks
The text was updated successfully, but these errors were encountered: